[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-modperl-dev
Subject:    Re: compatibility issue on internal_redirect
From:       Stefan Traby <stefan () hello-penguin ! com>
Date:       2004-02-21 1:15:12
Message-ID: 20040221011512.GC16700 () hello-penguin ! com
[Download RAW message or body]

On Mon, Feb 16, 2004 at 05:23:57PM -0800, Stas Bekman wrote:

Thanks for addressing this issue. I've tested current cvs
and it worked.

> Stas Bekman wrote:
> [...]
> >>>But you don't explain what you mean by a crippled STDOUT.
> >
> >[...]
> >
> >>--- internal_redirect.pm.orig   2004-02-11 19:43:40.000000000 +0100
> >>+++ internal_redirect.pm        2004-02-11 19:43:54.000000000 +0100
> >>@@ -21,6 +21,7 @@
> >>     else {
> >>         # main-req
> >>         my $redirect_uri = $args{uri};
> >>+        close STDOUT;
> >>         $r->internal_redirect("$redirect_uri?main=modperl");
> >>     }
> >>
> >>As I pointed out in my previous mail,
> >>modperl_io_perlio_override_stdout
> >>expects that STDOUT on input is valid which makes it incompatible
> >>with mod_perl_1.2x.
> >>
> >>And yes, I think that this is a bug (just because the function has 
> >>"override"
> >>in it's name). You can override an invalid handle.
> >>So the error is to croak when "dup" fails.
> >
> >
> >Thanks for the test case. I'll take a look at it and will get back to you.
> 
> Stefan, please try with the current cvs. That issue should be fixed now.
> 
> __________________________________________________________________
> Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
> http://stason.org/     mod_perl Guide ---> http://perl.apache.org
> mailto:stas@stason.org http://use.perl.org http://apacheweek.com
> http://modperlbook.org http://apache.org   http://ticketmaster.com
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
> 
> 

-- 

  ciao - 
    Stefan

"            aclocal - emit a warning if -ac kernel is used.             "

Stefan Traby                Linux/ia32             office: +49-721-3523165
Mathystr. 18-20 V/8         Linux/alpha              cell: +XX-XXX-XXXXXXX
76133 Karlsruhe             Linux/sparc               http://graz03.kwc.at
Germany                     Linux/arm               mailto:oesi@oesiman.de
Europe                      Linux/mips     mailto:stefan@hello-penguin.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]