[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-modperl-dev
Subject:    Re: [win32] mp2 recommended Perl?
From:       Stas Bekman <stas () stason ! org>
Date:       2002-12-15 4:04:16
[Download RAW message or body]

Randy Kobes wrote:
> On Fri, 13 Dec 2002, Stas Bekman wrote:
> 
> 
>>Kyle Oppenheim wrote:
>>
>>>>The build: currently we only warn about using 5.6.0 and
>>>>suggest to move to 5.6.1 at least. Though I doubt that
>>>>anybody sees that warning, as it gets swept away by
>>>>compiler's noise. I was suggesting before to move this note's
>>>>printing to the very end (or repeat twice?), so user will
>>>>notice it. Once we think it's prominent enough I suppose that
>>>>we can suggest to build with 5.8.0 for threaded mpms.
>>>
>>>If you are afraid people won't see it, you could just force
>>>them to acknowledge the warning.  Print an error; fail
>>>immediately; and prompt the user that they can workaround by
>>>specifying an additional argument to Makefile.PL or configure
>>>(e.g. --ignore_perl_version).
>>
>>Your idea is good. Though it can cause a problem with
>>unattended CPAN builds.  We will see how it goes and add
>>enforcements if we really need to later as we get closer to a
>>release date.
> 
> 
> How about, in the meantime, taking your suggestion and
> repeating the warning twice, as in

the place you added it to, is executed before the compilation, so usually not 
seen. What we really need, is to run this as the last thing of the Makefile's 
all: target. So meanwhile I've just committed the part of the patch that talks 
about WIN32.

> ==========================================================
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvspublic/modperl-2.0/Makefile.PL,v
> retrieving revision 1.87
> diff -u -r1.87 Makefile.PL
> --- Makefile.PL	29 Jun 2002 19:44:04 -0000	1.87
> +++ Makefile.PL	14 Dec 2002 17:43:34 -0000
> @@ -226,6 +226,7 @@
>                  "- or 'use Apache2 ();' in a startup script";
>      }
>  
> +    perl_version_check();
>      $build->save;
>  }
>  
> @@ -305,6 +306,11 @@
>          error "5.7.x development versions of Perl are no longer supported\n" .
>            "Upgrade to 5.8.0 or higher";
>          exit 1;
> +    }
> +
> +    if (WIN32 and $] < 5.008) {
> +        error "You are running a Perl version 5.6.x\n" .
> +          "We strongly suggest you upgrade to 5.8\n";
>      }
>  }
> 
> ================================================================
> 
> (perl_version_check() should be called at the beginning of the
> build also, as if one is using a 5.7 Perl, it exits immediately).  
> I also added a warning about using 5.6.x on Win32 specifically,
> as from previous posts, this combination seems particularly
> troublesome. I'll also update the Win32 docs to reflect this.
>  


-- 


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]