[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-moddtcl
Subject:    teeny bug in tcl_commands.c
From:       Simon.Greaves () usp ! ac ! fj
Date:       2001-01-04 2:45:53
[Download RAW message or body]

Hi,

using CVS version (from today), using the dtcl_info generates two sets
of info html. Quick look at tcl_commands.c, the Dtcl_Info function calls
both memwrite() and ap_rputs() sequentially. Presumably this should be
something like:

    if (buffer_output == 1)
      {
        memwrite(&obuffer, tble, strlen(tble));
      }
    else
      {
        ap_rputs(tble, global_rr);
      }

Patch attached.

Simon
-- 
Simon Greaves				voice: (+679) 212114
Computer Centre				fax:   (+679) 304089
The University of the South Pacific	email: Simon.Greaves@usp.ac.fj
Suva, Fiji


["tcl_commands.c.diff" (TEXT/plain)]

*** tcl_commands.c.orig	Thu Jan  4 14:42:06 2001
--- tcl_commands.c	Thu Jan  4 14:38:04 2001
***************
*** 444,452 ****
  		       "</table>\n"
  		       "</td></tr></table>\n", cacheFreeSize, getpid());
  /*     print_headers(global_rr);
!     flush_output_buffer(global_rr);  */
!     memwrite(&obuffer, tble, strlen(tble));
!     ap_rputs(tble, global_rr);
      return TCL_OK;
  }
  
--- 444,459 ----
  		       "</table>\n"
  		       "</td></tr></table>\n", cacheFreeSize, getpid());
  /*     print_headers(global_rr);
!        flush_output_buffer(global_rr); */
!     if (buffer_output == 1)
!       {
!         memwrite(&obuffer, tble, strlen(tble));
!       }
!     else
!       {
!         ap_rputs(tble, global_rr);
!       }
!     
      return TCL_OK;
  }
  


[prev in list] [next in list] [prev in thread] [next in thread]