[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: svn commit: r1914804 - in /httpd/httpd/trunk: changes-entries/flushing-chunks.txt modules/http/c
From:       Yann Ylavic <ylavic.dev () gmail ! com>
Date:       2023-12-21 10:32:27
Message-ID: CAKQ1sVMeY68PNu-dKCZoZ616Ck-BtmFvuAgDSP6YU6Fn_uYo=g () mail ! gmail ! com
[Download RAW message or body]

On Wed, Dec 20, 2023 at 5:50 PM Joe Orton <jorton@redhat.com> wrote:
> 
> On Wed, 20 Dec 2023, 16:30 Yann Ylavic, <ylavic.dev@gmail.com> wrote:
> > 
> > For the last-chunk, I think we need
> 
> I think that's not necessary because in the special case eos=flush, in the normal \
> case flush is NULL. Actually the reordering of the tests above doesn't make any \
> difference either, I could have skipped that. In the first iteration of the patch I \
> renamed eos to "terminator" to make it more obvious.

You are right, I missed that "eos = e" and not "eos =
APR_BUCKET_NEXT(e)" in this case.
My noise, all good!

Regards;
Yann.


[prev in list] [next in list] [prev in thread] [next in thread]