[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c
From:       "Graham Leggett via dev" <dev () httpd ! apache ! org>
Date:       2023-12-02 9:56:00
Message-ID: 889A9F21-DFAA-478D-B85A-5DF90C9A609E () sharp ! fm
[Download RAW message or body]

On 24 Nov 2023, at 19:26, Ruediger Pluem <rpluem@apache.org> wrote:

> > We do - and we also need to apr_pstrdup() the dn to be consistent with the rest.
> 
> Why? dn is already apr_pstrdup from r->pool:
> 
> https://github.com/apache/httpd/blob/dc76ce4c43efb8c0c36a5990aeb0468a87458087/modules/ldap/util_ldap.c#L2133
> 

Looks like we were consistently wasteful due to lack of const, fixed in r1914281.

Regards,
Graham
—


[prev in list] [next in list] [prev in thread] [next in thread]