[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: svn commit: r1773397 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c
From:       Luca Toscano <toscano.luca () gmail ! com>
Date:       2018-03-31 8:59:57
Message-ID: CAFedD40PZYyyE=5ghj9Mc46RJqwETbyMGDaw=urWnaf265s_Cg () mail ! gmail ! com
[Download RAW message or body]

2017-01-31 10:53 GMT+01:00 Plüm, Rüdiger, Vodafone Group <
ruediger.pluem@vodafone.com>:

>
>
> > -----Ursprüngliche Nachricht-----
> > Von: Joe Orton [mailto:jorton@redhat.com]
> > Gesendet: Dienstag, 31. Januar 2017 10:42
> > An: dev@httpd.apache.org
> > Betreff: Re: svn commit: r1773397 - in /httpd/httpd/trunk: CHANGES
> > modules/proxy/mod_proxy.c
> >
> > On Mon, Jan 30, 2017 at 07:52:03AM -0500, Eric Covener wrote:
> > > I have a fix but not sure if the change should just be reverted. In
> > > the PR, the user changed the 2.2 config to make the ProxyPass within
> > > location and expected similar behavior.
> > >
> > > Should have probably just told them that exceptions just could not be
> > > done that way.
> > >
> > > PR config is
> > >
> > > ProxyPass /error !
> > > <Location />
> > >   ProxyPass http://foo/...
> > > </Location>
> > >
> > > It seemed useful at the time, but since stuffing the thing inside of
> > > Location is not all that more useful functionally, adding more code
> > > seems like a mistake.
> >
> > Asserting/documenting that higher-level exceptions don't apply for
> > ProxyPass within <Location> seems pretty reasonable to me.
> >
>
> +1


While reviewing https://bz.apache.org/bugzilla/show_bug.cgi?id=61225 I
tried to add some clarification with http://svn.apache.org/r1828069 (trunk
only for the moment, will wait a bit before backporting if anybody wants to
add/amend).

Luca

[Attachment #3 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-01-31 \
10:53 GMT+01:00 Plüm, Rüdiger, Vodafone Group <span dir="ltr">&lt;<a \
href="mailto:ruediger.pluem@vodafone.com" \
target="_blank">ruediger.pluem@vodafone.com</a>&gt;</span>:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><br> <br>
&gt; -----Ursprüngliche Nachricht-----<br>
&gt; Von: Joe Orton [mailto:<a \
href="mailto:jorton@redhat.com">jorton@redhat.com</a>]<br> &gt; Gesendet: Dienstag, \
31. Januar 2017 10:42<br> &gt; An: <a \
href="mailto:dev@httpd.apache.org">dev@httpd.apache.org</a><br> &gt; Betreff: Re: svn \
commit: r1773397 - in /httpd/httpd/trunk: CHANGES<br> &gt; \
modules/proxy/mod_proxy.c<br> <span class="gmail-">&gt;<br>
&gt; On Mon, Jan 30, 2017 at 07:52:03AM -0500, Eric Covener wrote:<br>
&gt; &gt; I have a fix but not sure if the change should just be reverted. In<br>
&gt; &gt; the PR, the user changed the 2.2 config to make the ProxyPass within<br>
&gt; &gt; location and expected similar behavior.<br>
&gt; &gt;<br>
&gt; &gt; Should have probably just told them that exceptions just could not be<br>
&gt; &gt; done that way.<br>
&gt; &gt;<br>
&gt; &gt; PR config is<br>
&gt; &gt;<br>
&gt; &gt; ProxyPass /error !<br>
&gt; &gt; &lt;Location /&gt;<br>
&gt; &gt;     ProxyPass <a href="http://foo/." rel="noreferrer" \
target="_blank">http://foo/.</a>..<br> &gt; &gt; &lt;/Location&gt;<br>
&gt; &gt;<br>
&gt; &gt; It seemed useful at the time, but since stuffing the thing inside of<br>
&gt; &gt; Location is not all that more useful functionally, adding more code<br>
&gt; &gt; seems like a mistake.<br>
&gt;<br>
&gt; Asserting/documenting that higher-level exceptions don&#39;t apply for<br>
&gt; ProxyPass within &lt;Location&gt; seems pretty reasonable to me.<br>
&gt;<br>
<br>
</span>+1</blockquote><div><br></div><div>While reviewing <a \
href="https://bz.apache.org/bugzilla/show_bug.cgi?id=61225">https://bz.apache.org/bugzilla/show_bug.cgi?id=61225</a> \
I tried to add some clarification with <a \
href="http://svn.apache.org/r1828069">http://svn.apache.org/r1828069</a> (trunk only \
for the moment, will wait a bit before backporting if anybody wants to \
add/amend).</div><div><br></div><div>Luca  </div></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]