[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: svn commit: r1387110 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_proxy.xml include/ap_m
From:       Jim Jagielski <jim () jaguNET ! com>
Date:       2012-09-18 18:09:19
Message-ID: EB1F507E-C834-46DC-B5DE-55DB7EAFCD41 () jaguNET ! com
[Download RAW message or body]


On Sep 18, 2012, at 12:26 PM, Rüdiger Plüm <ruediger.pluem@vodafone.com> wrote:

> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.c?rev=1387110&r1=1387109&r2=1387110&view=diff
>  ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Tue Sep 18 12:15:50 2012
> @@ -1145,13 +1145,14 @@ static void * create_proxy_config(apr_po
> #if 0
> id = ap_proxy_hashfunc(apr_psprintf(p, "%pp-%" APR_TIME_T_FMT, ps, apr_time_now()), \
> PROXY_HASHFUNC_DEFAULT); #else
> -    id = ap_proxy_hashfunc(apr_psprintf(p, "%pp", ps), PROXY_HASHFUNC_DEFAULT);
> +    id = ap_proxy_hashfunc(apr_psprintf(p, "%pp", s), PROXY_HASHFUNC_DEFAULT);
> 
> Wouldn't multiple balancers within the same virtual server end up wit the same id \
> now? 

That ID is used to store the conf slot, which stores the list
of balancers for that server. Each balancer has it's own
slotmem instance which houses the workers.

Since 's' survives restarts, the conf->id remains constant
and thus we can restore.


[prev in list] [next in list] [prev in thread] [next in thread]