[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    RE: svn commit: r1303435 - /httpd/httpd/trunk/server/mpm_unix.c
From:       Plüm,_Rüdiger,_Vodafone_Group <ruediger.pluem () vodafone ! 
Date:       2012-03-22 15:15:47
Message-ID: AB1691BE05AE7F4992697F2A0835627A04ECC9 () VOEXM10W ! internal ! vodafone ! com
[Download RAW message or body]



> > >> > @@ -937,7 +937,7 @@ AP_DECLARE(apr_status_t) ap_fatal_signal
> > >> >
> > >> >  #endif /* NO_USE_SIGACTION */
> > >> >
> > >> > -    pconf = in_pconf;
> > >> > +    pconf = pconf;
> > >> >     parent_pid = my_pid = getpid();
> > >>
> > >> Doesn't the parameter name need to be changed back?
> > >
> > > IMHO not. The definition was synced with what we had in the header
> > file.
> > > Although this is not required from compiler perspective I prefer
> > header and c file
> > > in sync on the parameter names as well.
> >
> > Isn't the global pconf shadowed by the changed parameter name, or
> does
> > this assignment really do something?
> 
> 
> AH. Now I see what you mean. Yeah, that should be fixed. So in_pconf
> everywhere
> (header file, function definition in c file, function body).
> I am busy today, so if you like feel free to adjust.
> 

Found some time. Fixed in r1303827.

Regards

Rüdiger
[prev in list] [next in list] [prev in thread] [next in thread]