[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: Arranging mod_proxy_balancer in trunk
From:       Jim Jagielski <jim () jaguNET ! com>
Date:       2010-04-15 12:07:39
Message-ID: AC971378-6E89-481F-BFBF-708A01A05ECF () jaguNET ! com
[Download RAW message or body]


On Apr 14, 2010, at 1:31 PM, jean-frederic clere wrote:

> On 04/14/2010 07:26 PM, Jim Jagielski wrote:
>> 
>> On Apr 14, 2010, at 1:10 PM, jean-frederic clere wrote:
>>>>>> You should also likely pass a int * (or something) to handle
>>>>>> the requirement to also "know" total_factor outside of that
>>>>>> call... Of course, lbstatus is something that outside code
>>>>>> shouldn't really know about, but that's a whole 'nother
>>>>>> point ;)
>>>>> 
>>>>> total_factor in fact depends on the LB implementation I don't think it
>>>>> should go outside it.
>>>>> 
>>>> 
>>>> I agree... So elected == runtime then??
>>> 
>>> Well you meant we don't need runtime and could use *worker instead don't
>>> you?
>>> 
>> 
>> Well, looking at:
>> 
>>       runtime->s->lbstatus -= total_factor;
>>       runtime->s->elected++;
>> 
>> we need to have that section of code (either within the
>> new function or externally) update lbstatus and
>> elected. If 'total_factor' isn't exposed, then that
>> implies that runtime needs to be passed, right?
>> So I'm assuming that in
>> 
>>    apr_status_t (*updatelbstatus)(proxy_balancer *balancer, proxy_worker *elected, server_rec *s);
>> 
>> that you're using elected to pass runtime??
> 
> Sure, should I rename elected to runtime in the prototype?
> 

No need... I just wasn't sure that was what it was being used for,
hence by orig comments about needing to "expose" total_factor.
[prev in list] [next in list] [prev in thread] [next in thread]