[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: svn commit: r327945 - in /httpd/httpd/trunk: CHANGES modules/http/http_core.c modules/http/http_
From:       Brian Pane <brianp () apache ! org>
Date:       2005-10-30 22:03:40
Message-ID: 5983E31E-A1F4-48A7-9F90-D36F8F65E1C1 () apache ! org
[Download RAW message or body]

On Oct 30, 2005, at 4:17 AM, Joe Orton wrote:

> On Sun, Oct 30, 2005 at 09:56:45AM +0000, Joe Orton wrote:
>
>> On Sat, Oct 29, 2005 at 02:23:51PM -0700, Brian Pane wrote:
>>
>>> With fix 329484 committed, I'm now getting a clean test run of the
>>> perl_framework tests with --enable-pool-debug=all
>>>
>>
>> Thanks, all test runs passed last night here too.
>>
>
> Hmm, lots of segfaults from some manual testing though:
> ap_process_http_connection is using r after r->pool is destroyed:
>
> ...
>             ap_process_request(r);
>
>         if (ap_extended_status)
>             ap_increment_counts(c->sbh, r);
> ...
>         ap_update_child_status(c->sbh, SERVER_BUSY_KEEPALIVE, r);

The cleanest fix I can think of is to run the ap_increment_counts and
ap_update_child_status from the EOR bucket destruction function,
before r->pool is freed.  I'll implement the change later today.

Brian

[prev in list] [next in list] [prev in thread] [next in thread]