[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-httpd-dev
Subject:    Re: mod_rewrite: different behaviour on sub-requests - Why?
From:       "Ralf S. Engelschall" <rse () engelschall ! com>
Date:       2003-07-28 9:47:57
[Download RAW message or body]


>> Can somebody enlight me what this code in mod_rewrite.c is good for?
>> 
>> static int hook_fixup(request_rec *r)
>> {
>>    [...]
>>     /* we shouldn't do anything in subrequests */
>>     if (r->main != NULL) {
>>         return DECLINED;
>>     }
>> 
>> It took me days to track down what is is not good for
>> (see bug http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21814 ).
>> 
>> I suggest to disarm this section if not removing it from mod_rewrite.c...
> 
> This was added immediately after the inclusion of mod_rewrite into
> the httpd code (some years ago). I believe, the only one who can say,
> _why_ this was added, is Ralf :). However, I'll take a look into it.
> This was probably added in order to avoid mod_rewrite-loops. Perhaps
> it isn't necessary any longer.

No, sorry, I cannot remember myself. But you can be right, it looks like
it was to prevent loops. The only other possible reason I can think of
is that it was to perhaps speed up processing. But, as I said, I no
longer can remember the real reason.

                                       Ralf S. Engelschall
                                       rse@engelschall.com
                                       www.engelschall.com

[prev in list] [next in list] [prev in thread] [next in thread]