[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-docs
Subject:    Re: svn commit: r417203 - in /httpd/httpd/trunk/docs/manual/rewrite: flags.html flags.html.en flags.
From:       "Joshua Slive" <joshua () slive ! ca>
Date:       2006-06-26 15:20:02
Message-ID: e498c1660606260820w30cb187fgb5960239dc3ec3b9 () mail ! gmail ! com
[Download RAW message or body]

Looks good.  A few nitpicks below.

On 6/26/06, rbowen@apache.org <rbowen@apache.org> wrote:
> +<section id="flag_c"><title>C|chain</title>
> +<p>The [C] or [chain] flag indicates that the <directive
> +module="mod_rewrite">RewriteRule</directive> is chained to the next
> +rule. That is, if the rule matches, then it is processed as usual and
> +control moves on to the next rule. However, if it does not match, then
> +the next rule, and any other ruls that are chained together, will be
> +skipped.</p>

Missing an "e" on ruls.  I would also make this a touch more precise
by saying: "If it does not match, then the next rule will be skipped.
The chain can be extended to multiple consecutive rules, with the
first non-matching rule causing the entire remaining chain to be
skipped."

> +<section id="flag_e"><title>E|env</title>
> +<p>With the [E], or [env] flag, you can set the value of an environment
> +variable. Note that some variables may be set after the rule is run, and
> +so setting them in the <directive
> +module="mod_rewrite">RewriteRule</directive> won't work, since it will
> +be changed afterwards.</p>

I don't think that is very precise.  I had to read it a few times to
understand you are talking about variables being overriden before
being passed to CGI scripts.  I suggest simply linking to the env.html
doc, which explains this more explicitly.

Joshua.

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org

[prev in list] [next in list] [prev in thread] [next in thread]