[prev in list] [next in list] [prev in thread] [next in thread] 

List:       apache-cvs
Subject:    svn commit: r1834318 - in /httpd/httpd/trunk: CHANGES server/vhost.c
From:       covener () apache ! org
Date:       2018-06-25 13:18:24
Message-ID: 20180625131825.0D54A3A0163 () svn01-us-west ! apache ! org
[Download RAW message or body]

Author: covener
Date: Mon Jun 25 13:18:24 2018
New Revision: 1834318

URL: http://svn.apache.org/viewvc?rev=1834318&view=rev
Log:
Re-allow '_' (underscore) in hostnames.

'_' was not permitted in hostnames since 2.4.25's "HTTP Strict"
changes.


Modified:
    httpd/httpd/trunk/CHANGES
    httpd/httpd/trunk/server/vhost.c

Modified: httpd/httpd/trunk/CHANGES
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1834318&r1=1834317&r2=1834318&view=diff
 ==============================================================================
--- httpd/httpd/trunk/CHANGES [utf-8] (original)
+++ httpd/httpd/trunk/CHANGES [utf-8] Mon Jun 25 13:18:24 2018
@@ -1,5 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.1
+
+  *) core: Re-allow '_' (underscore) in hostnames.
+     [Eric Covener]
+
   *) ru, zh-cn and zh-tw translations of errordocs have been added.
      Contributed by Alexander Gaganashvili and CodeingBoy
   

Modified: httpd/httpd/trunk/server/vhost.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/vhost.c?rev=1834318&r1=1834317&r2=1834318&view=diff
 ==============================================================================
--- httpd/httpd/trunk/server/vhost.c (original)
+++ httpd/httpd/trunk/server/vhost.c Mon Jun 25 13:18:24 2018
@@ -760,7 +760,7 @@ static apr_status_t strict_hostname_chec
     int is_dotted_decimal = 1, leading_zeroes = 0, dots = 0;
 
     for (ch = host; *ch; ch++) {
-        if (apr_isalpha(*ch) || *ch == '-') {
+        if (apr_isalpha(*ch) || *ch == '-' || *ch == '_') {
             is_dotted_decimal = 0;
         }
         else if (ch[0] == '.') {


[prev in list] [next in list] [prev in thread] [next in thread]