[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Amarok 2.9.0 "Hibernaculum" released
From:       Mark Kretschmann <kretschmann () kde ! org>
Date:       2018-03-09 8:10:43
Message-ID: CAGzDjiODoDADDNC6AsWrmiFHXxVKZ_JP+2_TO5ThYmny__KOFg () mail ! gmail ! com
[Download RAW message or body]

So if you don't want to go through the hassle of checking it out from Git,
you could simply delete that one line in the source code, as indicated by
Heiko's linked patch.

Sorry for the trouble :)

Mark


On Fri, Mar 9, 2018 at 8:42 AM, Heiko Becker <heirecka@exherbo.org> wrote:

> Hello Michał,
>
> On 03/08/18 12:57, Michał Zając wrote:
> > /root/amarok/amarok-2.9.0/src/playlist/proxymodels/SortAlgorithms.cpp:
> > In member function ‘bool Playlist::multilevelLessThan::operator()(const
> > QAbstractItemModel*, int, int) const':
> > /root/amarok/amarok-2.9.0/src/playlist/proxymodels/
> SortAlgorithms.cpp:98:21:
> > error: expected primary-expression before ‘__attribute__'
> >                      __attribute__ ((fallthrough));
> >                      ^
> > src/CMakeFiles/amaroklib.dir/build.make:2716: recipe for target
> > 'src/CMakeFiles/amaroklib.dir/playlist/proxymodels/SortAlgorithms.cpp.o'
> > failed
> > make[2]: ***
> > [src/CMakeFiles/amaroklib.dir/playlist/proxymodels/SortAlgorithms.cpp.o]
> > Error 1
> > CMakeFiles/Makefile2:369: recipe for target
> > 'src/CMakeFiles/amaroklib.dir/all' failed
> > make[1]: *** [src/CMakeFiles/amaroklib.dir/all] Error 2
> > Makefile:138: recipe for target 'all' failed
> > make: *** [all] Error 2>
> > Am I the only one getting this?
>
> Unfortunately not, but it's already fixed in the 2.9 branch:
> https://cgit.kde.org/amarok.git/commit/?h=2.9&id=
> f047cd8219d9537bb33bba3883bedf6231a0ed5f
> (Or you can switch to gcc7).
>
> Regards,
> Heiko
>

[Attachment #3 (text/html)]

<div dir="ltr">So if you don&#39;t want to go through the hassle of checking it out \
from Git, you could simply delete that one line in the source code, as indicated by \
Heiko&#39;s linked patch.<div><br></div><div>Sorry for the trouble :)</div><div \
class="gmail_extra"><br></div><div class="gmail_extra">Mark</div><div \
class="gmail_extra"><br></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Fri, Mar 9, 2018 at 8:42 AM, Heiko Becker <span \
dir="ltr">&lt;<a href="mailto:heirecka@exherbo.org" \
target="_blank">heirecka@exherbo.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hello Michał,<br> <span class=""><br>
On 03/08/18 12:57, Michał Zając wrote:<br>
&gt; /root/amarok/amarok-2.9.0/src/<wbr>playlist/proxymodels/<wbr>SortAlgorithms.cpp:<br>
 &gt; In member function ‘bool \
Playlist::multilevelLessThan::<wbr>operator()(const<br> &gt; QAbstractItemModel*, \
int, int) const':<br> &gt; \
/root/amarok/amarok-2.9.0/src/<wbr>playlist/proxymodels/<wbr>SortAlgorithms.cpp:98:21:<br>
 &gt; error: expected primary-expression before ‘__attribute__'<br>
&gt;                                 __attribute__ ((fallthrough));<br>
&gt;                                 ^<br>
&gt; src/CMakeFiles/amaroklib.dir/<wbr>build.make:2716: recipe for target<br>
&gt; &#39;src/CMakeFiles/amaroklib.dir/<wbr>playlist/proxymodels/<wbr>SortAlgorithms.cpp.o&#39;<br>
 &gt; failed<br>
&gt; make[2]: ***<br>
&gt; [src/CMakeFiles/amaroklib.dir/<wbr>playlist/proxymodels/<wbr>SortAlgorithms.cpp.o]<br>
 &gt; Error 1<br>
&gt; CMakeFiles/Makefile2:369: recipe for target<br>
&gt; &#39;src/CMakeFiles/amaroklib.dir/<wbr>all&#39; failed<br>
&gt; make[1]: *** [src/CMakeFiles/amaroklib.dir/<wbr>all] Error 2<br>
&gt; Makefile:138: recipe for target &#39;all&#39; failed<br>
&gt; make: *** [all] Error 2&gt;<br>
&gt; Am I the only one getting this?<br>
<br>
</span>Unfortunately not, but it&#39;s already fixed in the 2.9 branch:<br>
<a href="https://cgit.kde.org/amarok.git/commit/?h=2.9&amp;id=f047cd8219d9537bb33bba3883bedf6231a0ed5f" \
rel="noreferrer" target="_blank">https://cgit.kde.org/amarok.<wbr>git/commit/?h=2.9&amp;id=<wbr>f047cd8219d9537bb33bba3883bedf<wbr>6231a0ed5f</a><br>
 (Or you can switch to gcc7).<br>
<br>
Regards,<br>
Heiko<br>
</blockquote></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]