[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 129192: Add namespace to desktop and appdata files
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2017-02-26 19:34:51
Message-ID: 20170226193451.3284.46949 () mimi ! kde ! org
[Download RAW message or body]
--===============3846848723233205617==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129192/#review102664
-----------------------------------------------------------
Ship it!
Matthias wrote:
> Pro: Works well on Wayland and allows using D-Bus activation. That is more \
> important than "just" being standard compliant.
Let's merge this to master (and thus kf5) then!
- Matěj Laitl
On Říj. 16, 2016, 4:12 odp., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129192/
> -----------------------------------------------------------
>
> (Updated Říj. 16, 2016, 4:12 odp.)
>
>
> Review request for Amarok and Matthias Klumpp.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> - add the organization namespace to the desktop and then appdata files, according \
> the specification;
> - use the new directory for metadata (metainfo) files.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 327ec10
> src/amarok.appdata.xml c580fd5
> src/amarok.desktop
> src/amarok_containers.desktop
> src/dbus/mpris2/MediaPlayer2.cpp a1d1bda
>
> Diff: https://git.reviewboard.kde.org/r/129192/diff/
>
>
> Testing
> -------
>
> Compiles, the files are installed in the expected places.
>
>
> Thanks,
>
> Luigi Toscano
>
>
--===============3846848723233205617==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129192/">https://git.reviewboard.kde.org/r/129192/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Matthias wrote:</p> <blockquote style="text-rendering: inherit;padding: 0 0 \
0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 \
0.5em;line-height: inherit;"> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Pro: Works well on Wayland and allows \
using D-Bus activation. That is more important than "just" being standard \
compliant.</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Let's merge this to master (and thus kf5) \
then!</p></pre> <br />
<p>- Matěj Laitl</p>
<br />
<p>On říjen 16th, 2016, 4:12 odp. CEST, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok and Matthias Klumpp.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Říj. 16, 2016, 4:12 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- add the organization namespace to the desktop and then appdata files, \
according the specification;
- use the new directory for metadata (metainfo) files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, the files are installed in the expected \
places.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(327ec10)</span></li>
<li>src/amarok.appdata.xml <span style="color: grey">(c580fd5)</span></li>
<li>src/amarok.desktop <span style="color: grey">()</span></li>
<li>src/amarok_containers.desktop <span style="color: grey">()</span></li>
<li>src/dbus/mpris2/MediaPlayer2.cpp <span style="color: grey">(a1d1bda)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129192/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3846848723233205617==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic