[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboa
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2016-10-16 10:12:34
Message-ID: 20161016101234.7699.87385 () mimi ! kde ! org
[Download RAW message or body]
--===============3249240740809413323==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129055/#review100036
-----------------------------------------------------------
Ship it!
Looks good. Feel free to push if you have commit access. Since kf5 is a development \
branch and there are few people to review, feel free to push to it directly unless \
you explicitly want a review (perhaps for something controversial).
- Matěj Laitl
On Zář. 27, 2016, 10:13 odp., Alexandr Akulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129055/
> -----------------------------------------------------------
>
> (Updated Zář. 27, 2016, 10:13 odp.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 :
> ```diff
> setText( i18n( "Play/Pause" ) );
> - setShortcut( Qt::Key_Space );
> - setGlobalShortcut( KShortcut() );
> + KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) );
> ```
>
> The change globally binds Key_Space, which breaks the key usage for the session.
>
>
> Diffs
> -----
>
> src/ActionClasses.cpp 77334fc
>
> Diff: https://git.reviewboard.kde.org/r/129055/diff/
>
>
> Testing
> -------
>
> Compiles.
>
>
> Thanks,
>
> Alexandr Akulich
>
>
--===============3249240740809413323==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129055/">https://git.reviewboard.kde.org/r/129055/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good. Feel free to push if you have commit access. Since kf5 is a development branch \
and there are few people to review, feel free to push to it directly unless you \
explicitly want a review (perhaps for something controversial).</p></pre> <br />
<p>- Matěj Laitl</p>
<br />
<p>On září 27th, 2016, 10:13 odp. CEST, Alexandr Akulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Alexandr Akulich.</div>
<p style="color: grey;"><i>Updated Zář. 27, 2016, 10:13 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There is a change at commit \
c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 :</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span></span> setText( \
i18n( "Play/Pause" ) ); <span style="color: #A00000">- setShortcut( \
Qt::Key_Space );</span> <span style="color: #A00000">- setGlobalShortcut( \
KShortcut() );</span> <span style="color: #00A000">+ \
KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) );</span> \
</pre></div> </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The change globally binds Key_Space, which breaks the \
key usage for the session.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ActionClasses.cpp <span style="color: grey">(77334fc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129055/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3249240740809413323==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic