[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 128418: Fix MPRIS2 DesktopEntry value
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-07-17 12:05:00
Message-ID: 20160717120500.20341.75241 () mimi ! kde ! org
[Download RAW message or body]
--===============4193848193426178422==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128418/#review97494
-----------------------------------------------------------
Can we just KAboutData desktopFileName or something like that? I fear when it gets \
renamed to org.kde.amarok at one point it'll break again.
- Kai Uwe Broulik
On Juli 10, 2016, 10:12 vorm., Antonio Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128418/
> -----------------------------------------------------------
>
> (Updated Juli 10, 2016, 10:12 vorm.)
>
>
> Review request for Amarok.
>
>
> Bugs: 365275
> https://bugs.kde.org/show_bug.cgi?id=365275
>
>
> Repository: amarok
>
>
> Description
> -------
>
> According to the MPRIS2 spec, the DesktopEntry value should be "the basename of the \
> .desktop file" [1], not the desktop-file-id. So for amarok it should be "amarok" \
> and not "kde4-amarok", regardless of where the desktop file is installed. This \
> fixes displaying MPRIS controls in the Amarok taskbar tooltip in Plasma 5.7
> [1] https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry
>
>
> Diffs
> -----
>
> src/dbus/mpris2/MediaPlayer2.cpp cbe1a2a
>
> Diff: https://git.reviewboard.kde.org/r/128418/diff/
>
>
> Testing
> -------
>
> Player controls are displayed again in the Amarok taskbar tooltip in Plasma 5.7.
>
>
> Thanks,
>
> Antonio Rojas
>
>
--===============4193848193426178422==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128418/">https://git.reviewboard.kde.org/r/128418/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can \
we just KAboutData desktopFileName or something like that? I fear when it gets \
renamed to org.kde.amarok at one point it'll break again.</p></pre> <br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Juli 10th, 2016, 10:12 vorm. UTC, Antonio Rojas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Antonio Rojas.</div>
<p style="color: grey;"><i>Updated Juli 10, 2016, 10:12 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=365275">365275</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to the MPRIS2 spec, the DesktopEntry value \
should be "the basename of the .desktop file" [1], not the desktop-file-id. So for \
amarok it should be "amarok" and not "kde4-amarok", regardless of where the desktop \
file is installed. This fixes displaying MPRIS controls in the Amarok taskbar tooltip \
in Plasma 5.7</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[1] \
https://specifications.freedesktop.org/mpris-spec/latest/Media_Player.html#Property:DesktopEntry</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Player controls are displayed again in the Amarok \
taskbar tooltip in Plasma 5.7.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dbus/mpris2/MediaPlayer2.cpp <span style="color: grey">(cbe1a2a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128418/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4193848193426178422==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic