[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 128246: Lyrics browser switched to the same background of the every other context
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2016-07-11 14:27:34
Message-ID: 20160711142734.603.4095 () mimi ! kde ! org
[Download RAW message or body]
--===============7853909024712827274==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128246/#review97291
-----------------------------------------------------------
Ship it!
Ship It!
- Matěj Laitl
On Čec. 10, 2016, 11:13 odp., Stefano Pettini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128246/
> -----------------------------------------------------------
>
> (Updated Čec. 10, 2016, 11:13 odp.)
>
>
> Review request for Amarok.
>
>
> Bugs: 314854
> https://bugs.kde.org/show_bug.cgi?id=314854
>
>
> Repository: amarok
>
>
> Description
> -------
>
> This makes the lyrics browser similar to every other context applet.
> Please note that, when editing lyrics, the default textbox background
> is still used.
>
>
> Diffs
> -----
>
> ChangeLog 23599f1
> src/context/applets/lyrics/LyricsBrowser.cpp abcfe64
>
> Diff: https://git.reviewboard.kde.org/r/128246/diff/
>
>
> Testing
> -------
>
> Tested ONLY in the following environment:
> KDE Version: 4.14.16
> Qt Version: 4.8.7
>
> Tested with light and dark color scheme
> Tested use case of changing KDE color scheme while Amarok is running
> Tested the edit lyrics mode
>
>
> Thanks,
>
> Stefano Pettini
>
>
--===============7853909024712827274==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128246/">https://git.reviewboard.kde.org/r/128246/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Matěj Laitl</p>
<br />
<p>On červenec 10th, 2016, 11:13 odp. CEST, Stefano Pettini wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Stefano Pettini.</div>
<p style="color: grey;"><i>Updated Čec. 10, 2016, 11:13 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=314854">314854</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This makes the lyrics browser similar to every other \
context applet. Please note that, when editing lyrics, the default textbox background
is still used.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested ONLY in the following environment: KDE Version: \
4.14.16 Qt Version: 4.8.7</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with light and dark color scheme Tested use \
case of changing KDE color scheme while Amarok is running Tested the edit lyrics \
mode</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(23599f1)</span></li>
<li>src/context/applets/lyrics/LyricsBrowser.cpp <span style="color: \
grey">(abcfe64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128246/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7853909024712827274==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic