[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 128248: Remove non SSL option for Wikipedia applet
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2016-06-20 20:27:49
Message-ID: 20160620202749.22783.33289 () mimi ! kde ! org
[Download RAW message or body]
--===============2563552490718284534==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128248/#review96755
-----------------------------------------------------------
Looks well, one minor thing below - unrelated change.
Also please mention:
BUG: 348313
..in the commit message and include a ChangeLog entry in the patch.
src/musicbrainz/MusicDNSAudioDecoder.cpp (line 226)
<https://git.reviewboard.kde.org/r/128248/#comment65359>
This looks like an unrelated change. Please strip of a probably post as a \
separate patch. Applies also to the change few lines below.
- Matěj Laitl
On Čer. 19, 2016, 11:44 dop., Olivier Churlaud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128248/
> -----------------------------------------------------------
>
> (Updated Čer. 19, 2016, 11:44 dop.)
>
>
> Review request for Amarok and Myriam Schweingruber.
>
>
> Bugs: 349313
> https://bugs.kde.org/show_bug.cgi?id=349313
>
>
> Repository: amarok
>
>
> Description
> -------
>
> I removed every possibility to use non SSL links
>
>
> Diffs
> -----
>
> src/context/applets/wikipedia/WikipediaApplet.cpp 2ceb2b0
> src/context/applets/wikipedia/wikipediaGeneralSettings.ui 84cb5df
> src/context/engines/wikipedia/WikipediaEngine.cpp 969d8fc
> src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b
>
> Diff: https://git.reviewboard.kde.org/r/128248/diff/
>
>
> Testing
> -------
>
> It compiles. However not tested, because make install always install in /usr/local, \
> whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't want to mess my install.
>
> Thanks,
>
> Olivier Churlaud
>
>
--===============2563552490718284534==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128248/">https://git.reviewboard.kde.org/r/128248/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
well, one minor thing below - unrelated change.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
please mention:
BUG: 348313
..in the commit message and include a ChangeLog entry in the patch.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128248/diff/1/?file=469271#file469271line226" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/musicbrainz/MusicDNSAudioDecoder.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">226</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">decodedFrame</span> <span class="o">=</span> <span class="n">av<span \
class="hl">codec</span>_alloc<span class="hl">_frame</span></span><span \
class="p">();</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">226</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="n">decodedFrame</span> <span class="o">=</span> <span class="n">av<span \
class="hl">_frame</span>_alloc</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
looks like an unrelated change. Please strip of a probably post as a separate patch. \
Applies also to the change few lines below.</p></pre> </div>
</div>
<br />
<p>- Matěj Laitl</p>
<br />
<p>On červen 19th, 2016, 11:44 dop. CEST, Olivier Churlaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok and Myriam Schweingruber.</div>
<div>By Olivier Churlaud.</div>
<p style="color: grey;"><i>Updated Čer. 19, 2016, 11:44 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349313">349313</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I removed every possibility to use non SSL \
links</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It compiles. However not tested, because make install \
always install in /usr/local, whatever I give in -DCMAKE_INSTALL_PREFIX. And I don't \
want to mess my install.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/wikipedia/WikipediaApplet.cpp <span style="color: \
grey">(2ceb2b0)</span></li>
<li>src/context/applets/wikipedia/wikipediaGeneralSettings.ui <span style="color: \
grey">(84cb5df)</span></li>
<li>src/context/engines/wikipedia/WikipediaEngine.cpp <span style="color: \
grey">(969d8fc)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.cpp <span style="color: \
grey">(ea39a1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128248/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2563552490718284534==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic