'Re: Review Request 125940: Fix mygpo-qt5 library finding'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: amarok-devel
Subject: Re: Review Request 125940: Fix mygpo-qt5 library finding
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2015-11-03 22:10:58
Message-ID: 20151103221058.24343.57917 () mimi ! kde ! org
[Download RAW message or body]

--===============0119916265708344889==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Nov. 3, 2015, 10:04 p.m., Stefan Derkits wrote:
> > cmake/modules/FindLibmygpo-qt.cmake, line 18
> > <https://git.reviewboard.kde.org/r/125940/diff/1/?file=414688#file414688line18>
> > 
> > seems to be installed in a non-standard path by the distribution, because the standard path \
> > is mygpo-qt for both the qt4 & qt5 build :( which distribution are you using? probably I \
> > should fix this upstream, bump the version number and then we can merge this review request
> 
> Andrea Scarpino wrote:
> Ah damn you are right :-(
> Seems libmygpo-qt5-git on Arch is patched to be co-installable with the qt4 version.

I will apply the patch upstream as many distributions seem to have problems if two versions of \
a library (even though they have the same header) use the same include path

- Stefan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125940/#review87967
-----------------------------------------------------------

On Nov. 3, 2015, 9:46 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125940/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 9:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> mygpo built with qt5 installs under /usr/include/mygpo-qt5 instead of mygpo-qt.
> 
> 
> Also, update the module name used in CMakeLists.txt
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 8cf9af3 
> cmake/modules/FindLibmygpo-qt.cmake a1af542 
> 
> Diff: https://git.reviewboard.kde.org/r/125940/diff/
> 
> 
> Testing
> -------
> 
> mygpo-qt5 is found.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
> 

--===============0119916265708344889==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125940/">https://git.reviewboard.kde.org/r/125940/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On November 3rd, 2015, 10:04 p.m. UTC, <b>Stefan Derkits</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/125940/diff/1/?file=414688#file414688line18" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/modules/FindLibmygpo-qt.cmake</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">18</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">  <span class="s">PATH_SUFFIXES</span> <span \
class="s">mygpo-qt</span></pre></td>  <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>  <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  \
<span class="s">PATH_SUFFIXES</span> <span class="s">mygpo-qt<span \
class="hl">5</span></span></pre></td>  </tr>

 </tbody>

</table>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">seems to be installed in a \
non-standard path by the distribution, because the standard path is mygpo-qt for both the qt4 \
&amp; qt5 build :( which distribution are you using? probably I should fix this upstream, bump \
the version number and then we can merge this review request</pre> </blockquote>

On November 3rd, 2015, 10:06 p.m. UTC, Andrea Scarpino wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ah damn you are right :-( Seems \
libmygpo-qt5-git on Arch is patched to be co-installable with the qt4 version.</pre> \
</blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I will apply \
the patch upstream as many distributions seem to have problems if two versions of a library \
(even though they have the same header) use the same include path</p></pre> <br />

<p>- Stefan</p>

<br />
<p>On November 3rd, 2015, 9:46 p.m. UTC, Andrea Scarpino wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Andrea Scarpino.</div>

<p style="color: grey;"><i>Updated Nov. 3, 2015, 9:46 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">mygpo built \
with qt5 installs under /usr/include/mygpo-qt5 instead of mygpo-qt.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, update \
the module name used in CMakeLists.txt</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">mygpo-qt5 is \
found.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(8cf9af3)</span></li>

 <li>cmake/modules/FindLibmygpo-qt.cmake <span style="color: grey">(a1af542)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125940/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0119916265708344889==--

[Attachment #3 (text/plain)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 