[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.
From: "Stefan Derkits" <stefan () derkits ! at>
Date: 2015-09-26 11:35:25
Message-ID: 20150926113525.14939.87165 () mimi ! kde ! org
[Download RAW message or body]
--===============7129570798775442817==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125394/#review85960
-----------------------------------------------------------
cmake/modules/FindLibLastFm.cmake (line 19)
<https://git.reviewboard.kde.org/r/125394/#comment59314>
the /usr/local/include/lastfm5 is incorret, instead the PATH_SUFFIXES should be \
changed to lastfm5
- Stefan Derkits
On Sept. 25, 2015, 8:42 p.m., Aditya Dev Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125394/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 8:42 p.m.)
>
>
> Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam \
> Schweingruber.
>
> Repository: amarok
>
>
> Description
> -------
>
> We need the Qt5 version of LibLastFm (ie liblastfm5) . Even after installing the \
> Qt5 version of the package, CMake showed not found.
>
> Diffs
> -----
>
> cmake/modules/FindLibLastFm.cmake 8fa607b
>
> Diff: https://git.reviewboard.kde.org/r/125394/diff/
>
>
> Testing
> -------
>
> Builds 100 %
>
>
> Thanks,
>
> Aditya Dev Sharma
>
>
--===============7129570798775442817==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125394/">https://git.reviewboard.kde.org/r/125394/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125394/diff/1/?file=408381#file408381line19" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/modules/FindLibLastFm.cmake</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">18</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">PATH_SUFFIXES</span> <span class="s">lastfm</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">19</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">PATH_SUFFIXES</span> <span class="s">lastfm</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the \
/usr/local/include/lastfm5 is incorret, instead the PATH_SUFFIXES should be changed \
to lastfm5</p></pre> </div>
</div>
<br />
<p>- Stefan Derkits</p>
<br />
<p>On September 25th, 2015, 8:42 p.m. UTC, Aditya Dev Sharma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam \
Schweingruber.</div> <div>By Aditya Dev Sharma.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2015, 8:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We need the Qt5 version of LibLastFm (ie liblastfm5) . \
Even after installing the Qt5 version of the package, CMake showed not \
found.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds 100 %</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindLibLastFm.cmake <span style="color: \
grey">(8fa607b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125394/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7129570798775442817==--
[Attachment #3 (text/plain)]
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic