'Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: amarok-devel
Subject: Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.
From: "Olivier Churlaud" <olivier () churlaud ! com>
Date: 2015-09-26 9:50:22
Message-ID: 20150926095022.14939.73451 () mimi ! kde ! org
[Download RAW message or body]

--===============5507594698742738245==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On sep. 25, 2015, 9:46 après-midi, Myriam Schweingruber wrote:
> > erm, /usr/local/include? are you sure? That folder is normally empty, I guess you \
> > meant /usr/include/liblastfm5, no?
> 
> Aditya Dev Sharma wrote:
> I'm quite sure about it. /usr/local/include was empty initially. But installing \
> LastFm (the Qt5 version) installed it there in /usr/local/include/lastfm5

I think it depends of how you install it. If you compile it manually (or use yaourt \
on arch) it goes to /usr/local/include. If you install it from a package, it goes to \
/usr/include.

- Olivier

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125394/#review85938
-----------------------------------------------------------

On sep. 25, 2015, 10:42 après-midi, Aditya Dev Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125394/
> -----------------------------------------------------------
> 
> (Updated sep. 25, 2015, 10:42 après-midi)
> 
> 
> Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam \
> Schweingruber. 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> We need the Qt5 version of LibLastFm (ie liblastfm5) . Even after installing the \
> Qt5 version of the package, CMake showed not found. 
> 
> Diffs
> -----
> 
> cmake/modules/FindLibLastFm.cmake 8fa607b 
> 
> Diff: https://git.reviewboard.kde.org/r/125394/diff/
> 
> 
> Testing
> -------
> 
> Builds 100 %
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
> 

--===============5507594698742738245==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125394/">https://git.reviewboard.kde.org/r/125394/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On septembre 25th, 2015, 9:46 après-midi CEST, \
<b>Myriam Schweingruber</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">erm, \
/usr/local/include? are you sure? That folder is normally empty, I guess you meant \
/usr/include/liblastfm5, no?</p></pre>  </blockquote>

On septembre 25th, 2015, 10:21 après-midi CEST, Aditya Dev Sharma \
wrote: <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm quite sure about it. /usr/local/include was empty initially. But \
installing LastFm (the Qt5 version) installed it there in \
/usr/local/include/lastfm5</pre> </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think it depends of how you install it. If you compile it manually (or use yaourt on \
arch) it goes to /usr/local/include. If you install it from a package, it goes to \
/usr/include.</p></pre> <br />

<p>- Olivier</p>

<br />
<p>On septembre 25th, 2015, 10:42 après-midi CEST, Aditya Dev Sharma wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam \
Schweingruber.</div> <div>By Aditya Dev Sharma.</div>

<p style="color: grey;"><i>Updated sep. 25, 2015, 10:42 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We need the Qt5 version of LibLastFm (ie liblastfm5) . \
Even after installing the Qt5 version of the package, CMake showed not \
found.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds 100 %</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindLibLastFm.cmake <span style="color: \
grey">(8fa607b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125394/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5507594698742738245==--

[Attachment #3 (text/plain)]

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 