'Re: Review Request 120930: "Flac" and "Mp3" modified to "FLAC" and "MP3" on dialog.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 120930: "Flac" and "Mp3" modified to "FLAC" and "MP3" on dialog.
From:       Matěj_Laitl <matej () laitl ! cz>
Date:       2014-11-01 10:06:42
Message-ID: 20141101100642.4239.4466 () probe ! kde ! org
[Download RAW message or body]

--===============0626669481915019761==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120930/#review69630
-----------------------------------------------------------

Ship it!

Looks good to me, thanks! Someone with commit access please push this. (please don't \
forget BUG, REVIEW, FIXED-IN tags)

- Matěj Laitl

On Oct. 31, 2014, 11:49 p.m., Duilio Felix wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120930/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 11:49 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 339495
> https://bugs.kde.org/show_bug.cgi?id=339495
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> [Bug 339495] "Flac" partially lowercase when ripping audio CD 
> 
> 
> Diffs
> -----
> 
> src/core-impl/collections/audiocd/FormatSelectionDialog.cpp 90cbb88 
> src/core-impl/collections/audiocd/FormatSelectionDialog.ui 9200301 
> 
> Diff: https://git.reviewboard.kde.org/r/120930/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Duilio Felix
> 
> 

--===============0626669481915019761==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120930/">https://git.reviewboard.kde.org/r/120930/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good to me, thanks! Someone with commit access please push this. (please don't forget \
BUG, REVIEW, FIXED-IN tags)</p></pre>  <br />

<p>- Matěj Laitl</p>

<br />
<p>On October 31st, 2014, 11:49 p.m. CET, Duilio Felix wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Duilio Felix.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2014, 11:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=339495">339495</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[Bug 339495] "Flac" partially lowercase when ripping \
audio CD </p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core-impl/collections/audiocd/FormatSelectionDialog.cpp <span style="color: \
grey">(90cbb88)</span></li>

 <li>src/core-impl/collections/audiocd/FormatSelectionDialog.ui <span style="color: \
grey">(9200301)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120930/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0626669481915019761==--

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 