'Re: Review Request 120399: Amarok: If waiting on the fadeout to pause, prevent pausing again.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 120399: Amarok: If waiting on the fadeout to pause,  prevent pausing again.
From:       Matěj_Laitl <matej () laitl ! cz>
Date:       2014-09-28 9:45:29
Message-ID: 20140928094529.15675.17841 () probe ! kde ! org
[Download RAW message or body]

--===============3648877528026696813==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120399/#review67549
-----------------------------------------------------------

The change looks good (it is an improvement wrt current situation), but perhaps we \
can do what you envisioned on the bug, i.e. pause instantenously when pause is \
pressed within pausin fadeout?

- Matěj Laitl

On Sept. 28, 2014, 2:39 a.m., Martin Lyth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120399/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 2:39 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 339470
> https://bugs.kde.org/show_bug.cgi?id=339470
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> Don't call play or pause if we're already waiting on the timer to pause. See Bug \
> 339470 for details on the bug, and the 1.5 lines of code are pretty \
> self-explanatory. 
> 
> Diffs
> -----
> 
> src/EngineController.cpp 19c483d 
> 
> Diff: https://git.reviewboard.kde.org/r/120399/diff/
> 
> 
> Testing
> -------
> 
> Still compiles, and pressing pause continuously no longer extends the timer \
> infinitely. 
> 
> Thanks,
> 
> Martin Lyth
> 
> 

--===============3648877528026696813==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120399/">https://git.reviewboard.kde.org/r/120399/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
change looks good (it is an improvement wrt current situation), but perhaps we can do \
what you envisioned on the bug, i.e. pause instantenously when pause is pressed \
within pausin fadeout?</p></pre>  <br />

<p>- Matěj Laitl</p>

<br />
<p>On September 28th, 2014, 2:39 a.m. CEST, Martin Lyth wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Martin Lyth.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2014, 2:39 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=339470">339470</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Don't call play or pause if we're already waiting on \
the timer to pause. See Bug 339470 for details on the bug, and the 1.5 lines of code \
are pretty self-explanatory.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Still compiles, and pressing pause continuously no \
longer extends the timer infinitely.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/EngineController.cpp <span style="color: grey">(19c483d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120399/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3648877528026696813==--

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 