[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 115154: Analyzer applet ASCII visualizer
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2014-07-26 7:36:00
Message-ID: 20140726073600.4048.66386 () probe ! kde ! org
[Download RAW message or body]
--===============2014980489234933721==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115154/#review63181
-----------------------------------------------------------
Ship it!
Hello Matej, only yesterday I saw your patch and immediately tried it out. So sorry \
for not replying earlier! Somehow I had missed this patch completely.
I quite like the idea of an ASCII visualization. It's simple and does not distract \
too much. The code is also fine, I don't see any issues with it. So I would like to \
see it in git master.
Shall we commit this patch for you, or do you have commit rights for the KDE git \
repo?
- Mark Kretschmann
On Jan. 20, 2014, 4:04 p.m., Matej Repinc wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115154/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2014, 4:04 p.m.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> ASCII visualization is an extension of the Analyzer applet, inspired by \
> Asciiquarium screensaver. It's based on Blocky visualization.
>
> Diffs
> -----
>
> src/context/applets/analyzer/ASCIIAnalyzer.h PRE-CREATION
> src/context/applets/analyzer/ASCIIAnalyzer.cpp PRE-CREATION
> src/context/applets/analyzer/AnalyzerApplet.cpp 5af5819
> src/context/applets/analyzer/CMakeLists.txt 9fc5b30
>
> Diff: https://git.reviewboard.kde.org/r/115154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matej Repinc
>
>
--===============2014980489234933721==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115154/">https://git.reviewboard.kde.org/r/115154/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hello \
Matej, only yesterday I saw your patch and immediately tried it out. So sorry for not \
replying earlier! Somehow I had missed this patch completely.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
quite like the idea of an ASCII visualization. It's simple and does not distract too \
much. The code is also fine, I don't see any issues with it. So I would like to see \
it in git master.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Shall we commit this patch for you, or \
do you have commit rights for the KDE git repo?</p></pre> <br />
<p>- Mark Kretschmann</p>
<br />
<p>On January 20th, 2014, 4:04 p.m. UTC, Matej Repinc wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Matej Repinc.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2014, 4:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ASCII visualization is an extension of the Analyzer applet, inspired by \
Asciiquarium screensaver. It's based on Blocky visualization.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/analyzer/ASCIIAnalyzer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/context/applets/analyzer/ASCIIAnalyzer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/context/applets/analyzer/AnalyzerApplet.cpp <span style="color: \
grey">(5af5819)</span></li>
<li>src/context/applets/analyzer/CMakeLists.txt <span style="color: \
grey">(9fc5b30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115154/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2014980489234933721==--
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic