'Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bia'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bia
From:       Matěj_Laitl <matej () laitl ! cz>
Date:       2014-07-23 15:14:34
Message-ID: 20140723151434.14617.84889 () probe ! kde ! org
[Download RAW message or body]

--===============3326285356293372063==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On July 23, 2014, 5:12 p.m., Matěj Laitl wrote:
> > Looks good to me, ship it and thanks. :)

Please don't forget to add relevant tags to commit:

REVIEW: ...
BUG: ...
FIXED-IN: ...

- Matěj

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119429/#review62969
-----------------------------------------------------------

On July 23, 2014, 5:07 p.m., Robert Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119429/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 5:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Bugs: 337725
> https://bugs.kde.org/show_bug.cgi?id=337725
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> [Bug 337725] Text for RandomBiasFactory says 'random tracks' but the text once \
> added is 'random songs' 
> 
> Diffs
> -----
> 
> src/dynamic/Bias.cpp d0aab75 
> src/dynamic/biases/SearchQueryBias.cpp cfe4b01 
> 
> Diff: https://git.reviewboard.kde.org/r/119429/diff/
> 
> 
> Testing
> -------
> 
> Built (kubuntu 14.04)
> Checked that existing dynamic mode playlists with 'random songs' displays the new \
> text Checked that random track addition to a playlist displays correctly.
> Checked that on running the playlist it looks like random tracks are being added
> 
> 
> Thanks,
> 
> Robert Marshall
> 
> 

--===============3326285356293372063==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119429/">https://git.reviewboard.kde.org/r/119429/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 23rd, 2014, 5:12 p.m. CEST, <b>Matěj \
Laitl</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks good to me, ship it and thanks. :)</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please don't forget to add relevant tags to commit:</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">REVIEW: ...<br style="padding: 0;text-rendering: inherit;margin: \
                0;line-height: inherit;white-space: normal;" />
BUG: ...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: normal;" />
FIXED-IN: ...</p></pre>
<br />

<p>- Matěj</p>

<br />
<p>On July 23rd, 2014, 5:07 p.m. CEST, Robert Marshall wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Robert Marshall.</div>

<p style="color: grey;"><i>Updated July 23, 2014, 5:07 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=337725">337725</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[Bug 337725] Text for RandomBiasFactory says 'random \
tracks' but the text once added is 'random songs'</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Built (kubuntu 14.04)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Checked that existing dynamic mode playlists with 'random songs' displays the new \
text<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> Checked that random track addition to a playlist \
displays correctly.<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> Checked that on running the playlist \
it looks like random tracks are being added</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/dynamic/Bias.cpp <span style="color: grey">(d0aab75)</span></li>

 <li>src/dynamic/biases/SearchQueryBias.cpp <span style="color: \
grey">(cfe4b01)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119429/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3326285356293372063==--

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 