'Re: Review Request 119405: Stop passing -std=iso9899:1999 to CMAKE_C_FLAGS.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 119405: Stop passing -std=iso9899:1999 to CMAKE_C_FLAGS.
From:       Matěj_Laitl <matej () laitl ! cz>
Date:       2014-07-23 7:26:07
Message-ID: 20140723072607.14617.82740 () probe ! kde ! org
[Download RAW message or body]

--===============3503320844770576241==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119405/#review62918
-----------------------------------------------------------

Ship it!

Looks good to me, push it! :)   (do you already have commit access?)

- Matěj Laitl

On July 22, 2014, 2:32 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119405/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 2:32 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> This was added back when Amarok built its own SQLite copy, which was
> removed in 2008 by commit 489af24a010eaeacbaf2f82b0f07ebd3b12c0912.
> 
> And even then, kdelibs itself already sets this same flag on its own.
> 
> 
> Diffs
> -----
> 
> src/core/CMakeLists.txt 5935c36bf03ff977b72f3bec74082ed15e39dea2 
> 
> Diff: https://git.reviewboard.kde.org/r/119405/diff/
> 
> 
> Testing
> -------
> 
> Still builds on Debian.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
> 

--===============3503320844770576241==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119405/">https://git.reviewboard.kde.org/r/119405/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good to me, push it! :)   (do you already have commit access?)</p></pre>  <br />

<p>- Matěj Laitl</p>

<br />
<p>On July 22nd, 2014, 2:32 p.m. CEST, Raphael Kubo da Costa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Raphael Kubo da Costa.</div>

<p style="color: grey;"><i>Updated July 22, 2014, 2:32 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This was added back when Amarok built its own SQLite \
copy, which was<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> removed in 2008 by commit \
489af24a010eaeacbaf2f82b0f07ebd3b12c0912.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">And even then, kdelibs \
itself already sets this same flag on its own.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Still builds on Debian.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/CMakeLists.txt <span style="color: \
grey">(5935c36bf03ff977b72f3bec74082ed15e39dea2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119405/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3503320844770576241==--

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 