'Re: Review Request 118005: Amarok use wrong url to query ampache'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 118005: Amarok use wrong url to query ampache
From:       "Dan Meltzer" <parallelgrapefruit () gmail ! com>
Date:       2014-05-08 0:39:52
Message-ID: 20140508003952.11253.53495 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118005/#review57540
-----------------------------------------------------------

Out of curiousity, what version of Ampache?  I can confirm that the url has \
/server/xml.server.php added twice, but this actually still works on ampache 3.5.0.  \
It works with it added once too, so it's not a big change, just wondering whats \
different on your ampache setup.

- Dan Meltzer

On May 5, 2014, 6:29 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118005/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 6:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> in AmpacheServiceQueryMaker.cpp, it append server/xml.server.php twice to the \
> request url, which is obviously wrong. I can confirm this behaviour from server \
> side log. Simply remove one of them will fix it. 
> 
> Diffs
> -----
> 
> src/services/ampache/AmpacheServiceQueryMaker.cpp b94c3b0 
> 
> Diff: https://git.reviewboard.kde.org/r/118005/diff/
> 
> 
> Testing
> -------
> 
> amarok now work with ampache again.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118005/">https://git.reviewboard.kde.org/r/118005/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Out of curiousity, what \
version of Ampache?  I can confirm that the url has /server/xml.server.php added \
twice, but this actually still works on ampache 3.5.0.  It works with it added once \
too, so it&#39;s not a big change, just wondering whats different on your ampache \
setup.</pre>  <br />

<p>- Dan Meltzer</p>

<br />
<p>On May 5th, 2014, 6:29 p.m. UTC, Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated May 5, 2014, 6:29 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">in AmpacheServiceQueryMaker.cpp, it append server/xml.server.php twice \
to the request url, which is obviously wrong. I can confirm this behaviour from \
server side log. Simply remove one of them will fix it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">amarok now work with ampache again.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/services/ampache/AmpacheServiceQueryMaker.cpp <span style="color: \
grey">(b94c3b0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118005/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 