[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dial
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2014-01-05 10:29:50
Message-ID: 20140105102950.15367.69774 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114752/#review46844
-----------------------------------------------------------
I see, this patch is almost ready, please wait for Yuri to answer and then fix \
remaining problems. Also please don't forget about: 1. Add commit tags to the \
description - see quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: \
BUG: ####, FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit - also \
please update the description to be current
src/widgets/MetaQueryWidget.cpp
<https://git.reviewboard.kde.org/r/114752/#comment33442>
So the maximum time is 23:59:59 - this calculation is wrong.
src/widgets/MetaQueryWidget.cpp
<https://git.reviewboard.kde.org/r/114752/#comment33443>
Please:
1. provide context for the string - use i18nc() call with context like "time \
format for specifying track length - hours, minutes, seconds" 2. respect Amarok \
coding style - spaces around arguments
- Matěj Laitl
On Jan. 5, 2014, 11:25 a.m., Abhay Sombanshi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114752/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2014, 11:25 a.m.)
>
>
> Review request for Amarok and Yuri Chornoivan.
>
>
> Bugs: 291400
> https://bugs.kde.org/show_bug.cgi?id=291400
>
>
> Repository: amarok
>
>
> Description
> -------
>
> CollectionBrowser filter dialog will now allow a length of 24 hours.
>
>
> Diffs
> -----
>
> ChangeLog 0eb03c8
> src/widgets/MetaQueryWidget.cpp 58601cc
>
> Diff: https://git.reviewboard.kde.org/r/114752/diff/
>
>
> Testing
> -------
>
> works as expected.
>
>
> Thanks,
>
> Abhay Sombanshi
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114752/">https://git.reviewboard.kde.org/r/114752/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see, this patch is \
almost ready, please wait for Yuri to answer and then fix remaining problems. Also \
please don't forget about: 1. Add commit tags to the description - see \
quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: BUG: \
####, FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit - also please \
update the description to be current</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114752/diff/3/?file=230082#file230082line217" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgets/MetaQueryWidget.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">MetaQueryWidget::Filter::maximumValue( quint64 field )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">215</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">Meta</span>:<span class="o">:</span><span \
class="n">valLength</span><span class="o">:</span> <span class="k">return</span> \
<span class="mi">60</span> <span class="o">*</span> <span class="mi">60</span> <span \
class="o">+</span> <span class="mi">59</span><span class="p">;</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">217</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">Meta</span>:<span class="o">:</span><span \
class="n">valLength</span><span class="o">:</span> <span class="k">return</span> \
<span class="n"><span class="hl">maxHours</span></span><span class="hl"> </span><span \
class="o"><span class="hl">*</span></span><span class="hl"> </span><span \
class="mi">60</span> <span class="o">*</span> <span class="mi">60</span> <span \
class="o">+</span> <span class="mi">59</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So the \
maximum time is 23:59:59 - this calculation is wrong.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114752/diff/3/?file=230082#file230082line846" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/widgets/MetaQueryWidget.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">MetaQueryWidget::makeRatingSelection()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">846</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">displayFormat</span> <span \
class="o">=</span> <span class="n">i18n</span><span class="p">(</span><span \
class="s">"h:m:ss"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please: 1. \
provide context for the string - use i18nc() call with context like "time format \
for specifying track length - hours, minutes, seconds" 2. respect Amarok coding \
style - spaces around arguments</pre> </div>
<br />
<p>- Matěj Laitl</p>
<br />
<p>On January 5th, 2014, 11:25 a.m. CET, Abhay Sombanshi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok and Yuri Chornoivan.</div>
<div>By Abhay Sombanshi.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2014, 11:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=291400">291400</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CollectionBrowser filter dialog will now allow a length of 24 \
hours.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(0eb03c8)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(58601cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114752/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic