[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 114736: Bug 299431 The text in the notification area
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2014-01-03 13:05:54
Message-ID: 20140103130554.11858.54670 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114736/#review46687
-----------------------------------------------------------
Hi, the patch looks very good, thanks for it!
To help us even more, please:
1. attach a screenshot here (similar to the attachment of bug \
https://bugs.kde.org/show_bug.cgi?id=299431 ) showing how the problem is fixed 2. \
Add commit tags to the description - see \
quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: BUG: ####, \
FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit 3. Add a line to the \
ChangeLog file (top-level in the repo) - under BUGFIXES on top.
src/statusbar/ProgressBar.cpp
<https://git.reviewboard.kde.org/r/114736/#comment33330>
Please respect Amarok coding style (see folder named HACKING) - spaces around \
arguments.
- Matěj Laitl
On Dec. 30, 2013, 7:20 a.m., Nilesh Suthar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114736/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2013, 7:20 a.m.)
>
>
> Review request for Amarok.
>
>
> Bugs: 299431
> https://bugs.kde.org/show_bug.cgi?id=299431
>
>
> Repository: amarok
>
>
> Description
> -------
>
> QLabel for CompoundProgressbar was croping out the description from above and below \
> because QLabel default alignment is set to Horizontal left and vertical \
> Center.Changed to Vertical Top.Added Ellipsis for text overflow and tooltip to view \
> the description
>
> Diffs
> -----
>
> src/statusbar/ProgressBar.cpp 400390f
>
> Diff: https://git.reviewboard.kde.org/r/114736/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nilesh Suthar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114736/">https://git.reviewboard.kde.org/r/114736/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, the patch looks very \
good, thanks for it!
To help us even more, please:
1. attach a screenshot here (similar to the attachment of bug \
https://bugs.kde.org/show_bug.cgi?id=299431 ) showing how the problem is fixed 2. \
Add commit tags to the description - see \
quickgit.kde.org/?p=kdelibs.git&a=blob&f=.commit-template - namely: BUG: \
####, FIXED-IN: 2.9, REVIEW: ### - so that they end up in the commit 3. Add a line \
to the ChangeLog file (top-level in the repo) - under BUGFIXES on top.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114736/diff/1/?file=227933#file227933line79" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/statusbar/ProgressBar.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">ProgressBar::~ProgressBar()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">79</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_descriptionLabel</span><span class="o">-></span><span \
class="n">setText</span><span class="p">(</span> <span class="n">description</span> \
<span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">79</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QFontMetrics</span> <span \
class="n">metrics</span><span class="p">(</span><span \
class="n">m_descriptionLabel</span><span class="o">-></span><span \
class="n">font</span><span class="p">());</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">80</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">elidedDescription</span> <span \
class="o">=</span> <span class="n">metrics</span><span class="p">.</span><span \
class="n">elidedText</span><span class="p">(</span><span \
class="n">description</span><span class="p">,</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">ElideRight</span><span class="p">,</span> <span \
class="n">m_descriptionLabel</span><span class="o">-></span><span \
class="n">width</span><span class="p">());</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">81</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_descriptionLabel</span><span class="o">-></span><span \
class="n">setAlignment</span><span class="p">(</span><span class="n">Qt</span><span \
class="o">::</span><span class="n">AlignLeft</span><span class="o">|</span><span \
class="n">Qt</span><span class="o">::</span><span class="n">AlignTop</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
respect Amarok coding style (see folder named HACKING) - spaces around \
arguments.</pre> </div>
<br />
<p>- Matěj Laitl</p>
<br />
<p>On December 30th, 2013, 7:20 a.m. CET, Nilesh Suthar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Nilesh Suthar.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2013, 7:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=299431">299431</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QLabel for CompoundProgressbar was croping out the description from \
above and below because QLabel default alignment is set to Horizontal left and \
vertical Center.Changed to Vertical Top.Added Ellipsis for text overflow and tooltip \
to view the description</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/statusbar/ProgressBar.cpp <span style="color: grey">(400390f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114736/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic