'Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag
From:       "Martin Brodbeck" <martin () brodbeck-online ! de>
Date:       2013-12-12 10:51:23
Message-ID: 20131212105123.24580.95953 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114406/
-----------------------------------------------------------

(Updated Dec. 12, 2013, 11:51 a.m.)

Review request for Amarok and Matěj Laitl.

Changes
-------

Err, committing? me? :)
This is done by an active amarok developer, right? Otherwise, someone should tell me, \
how. ;) Anyway, I updated the patch with updated Changelog. (Is this diff format \
better?)

Bugs: 328451
    https://bugs.kde.org/show_bug.cgi?id=328451

Repository: amarok

Description
-------

With this patch, covers from Ogg files (for example Vorbis and Opus) using the \
recommended METADATA_BLOCK_PICTURE tag will be displayed. This will fix bug #328451. 

Diffs (updated)
-----

  ChangeLog 107aa48 
  shared/tag_helpers/VorbisCommentTagHelper.cpp dc02a1c 

Diff: http://git.reviewboard.kde.org/r/114406/diff/

Testing
-------

Thanks,

Martin Brodbeck

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114406/">http://git.reviewboard.kde.org/r/114406/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok and Matěj Laitl.</div>
<div>By Martin Brodbeck.</div>

<p style="color: grey;"><i>Updated Dec. 12, 2013, 11:51 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Err, committing? me? :) This is done by an active amarok developer, \
right? Otherwise, someone should tell me, how. ;) Anyway, I updated the patch with \
updated Changelog. (Is this diff format better?)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=328451">328451</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch, covers from Ogg files (for example Vorbis and Opus) \
using the recommended METADATA_BLOCK_PICTURE tag will be displayed. This will fix bug \
#328451. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>ChangeLog <span style="color: grey">(107aa48)</span></li>

 <li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: \
grey">(dc02a1c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114406/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 