This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113390/

src/CMakeLists.txt (Diff revision 1)
		484	#shouldn't be here

So where should it be? :)

src/amarokconfig.kcfg (Diff revision 1)
		596	<entry key="EnableDeprecationWarnings" type="Bool">

The user probably does not want to see meaningless errors about some script they installed. This is a debugging feature for developers, right?

src/configdialog/dialogs/ScriptsConfig.cpp (Diff revision 1)
		244	KMessageBox::error( this, i18n( "Please select a script!" ) );

Don't use exclamation marks in user-visible strings.

Also I'm wondering why an error dialog is shown here. Maybe the button should simply be disabled if nothing is selected. Then there would be no need for error handling.

src/configdialog/dialogs/ScriptsConfig.cpp (Diff revision 1)
		249	int response = KMessageBox::warningContinueCancel( this, i18n( "You are advised to only uninstall manually "

Please reword the string. It's pretty unclear.

E.g. "Default scripts that are bundled with Amarok cannot be uninstalled."

src/configdialog/dialogs/ScriptsConfig.cpp (Diff revision 1)
		278	const KArchiveFile *file = findSpecFile( subDir );

Can be changed to:

return findSpecFile( subdir );

- Mark Kretschmann

On October 22nd, 2013, 4:06 p.m. UTC, Anmol Ahuja wrote:

Review request for Amarok.

By Anmol Ahuja.

Updated Oct. 22, 2013, 4:06 p.m.

Repository: amarok

Description

Miscellaneous changes made in the src/ folder.

Diffs

src/App.h (9ee071d)
src/App.cpp (eb3f483)
src/CMakeLists.txt (70fb67b)
src/EngineController.h (80ec17b)
src/EngineController.cpp (cf29cf8)
src/amarokconfig.kcfg (84cfa5b)
src/amarokurls/BookmarkGroup.h (ea42c30)
src/browsers/CollectionTreeItem.h (0a5d197)
src/browsers/CollectionTreeItem.cpp (4c35523)
src/browsers/CollectionTreeItemModelBase.h (00e99fb)
src/browsers/CollectionTreeView.h (454a70d)
src/browsers/CollectionTreeView.cpp (6fad164)
src/browsers/collectionbrowser/CollectionWidget.h (7480015)
src/browsers/collectionbrowser/CollectionWidget.cpp (95a16dc)
src/configdialog/dialogs/ScriptSelector.h (9ce1168)
src/configdialog/dialogs/ScriptSelector.cpp (117cedf)
src/configdialog/dialogs/ScriptsConfig.h (6a47847)
src/configdialog/dialogs/ScriptsConfig.cpp (714b63e)
src/configdialog/dialogs/ScriptsConfig.ui (b4b8d37)
src/context/applets/lyrics/LyricsApplet.cpp (7db356d)
src/context/applets/songkick/SongkickApplet.cpp (ed93e56)
src/context/engines/lyrics/LyricsEngine.cpp (d3273b0)
src/core-impl/collections/support/jobs/WriteTagsJob.h (a92ab8d)
src/core-impl/collections/support/jobs/WriteTagsJob.cpp (5834cd4)
src/core/collections/Collection.h (94d24d7)
src/core/collections/QueryMaker.h (92b6a65)
src/core/meta/support/MetaConstants.cpp (40d7122)
src/dialogs/DiagnosticDialog.cpp (c9bfce6)
src/dialogs/EqualizerDialog.h (6c9e19e)
src/dialogs/EqualizerDialog.cpp (acf0da0)
src/dialogs/deviceconfiguredialog.cpp (e54edad)
src/dynamic/BiasFactory.cpp (2a887c2)
src/dynamic/TrackSet.h (dee8ee3)
src/dynamic/TrackSet.cpp (456a10a)
src/equalizer/EqualizerPresets.h (be8d267)
src/equalizer/EqualizerPresets.cpp (b9aa13b)
src/playback/EqualizerController.h (PRE-CREATION)
src/playback/EqualizerController.cpp (PRE-CREATION)
src/playlistmanager/PlaylistManager.h (a835c35)
src/services/scriptable/ScriptableService.cpp (f254e3e)
src/services/scriptable/ScriptableServiceInfoParser.cpp (998135b)
src/services/scriptable/ScriptableServiceManager.cpp (aa28a6c)
src/services/scriptable/ScriptableServiceQueryMaker.cpp (07233dd)

View Diff