[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 113387: GSoC 2013 Revamping Scripting - Part 4/6 : Script Console
From: "Mark Kretschmann" <kretschmann () kde ! org>
Date: 2013-11-16 13:01:47
Message-ID: 20131116130147.29148.96465 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113387/#review43814
-----------------------------------------------------------
src/scripting/scriptconsole/ScriptConsole.h
<http://git.reviewboard.kde.org/r/113387/#comment31452>
Why is this class commented out? Never keep commented out code, unless there is a \
very good reason to, and also an extra comment explaining why it is there.
src/scripting/scriptconsole/ScriptConsole.cpp
<http://git.reviewboard.kde.org/r/113387/#comment31456>
Remove commented out code.
src/scripting/scriptconsole/ScriptConsole.cpp
<http://git.reviewboard.kde.org/r/113387/#comment31455>
Please clean up this function.
src/scripting/scriptconsole/ScriptConsole.cpp
<http://git.reviewboard.kde.org/r/113387/#comment31454>
Remove commented out code.
src/scripting/scriptconsole/ScriptConsole.cpp
<http://git.reviewboard.kde.org/r/113387/#comment31453>
Remove commented out code.
- Mark Kretschmann
On Oct. 22, 2013, 4:06 p.m., Anmol Ahuja wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113387/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 4:06 p.m.)
>
>
> Review request for Amarok.
>
>
> Repository: amarok
>
>
> Description
> -------
>
> The new script console.
>
>
> Diffs
> -----
>
> src/scripting/scriptconsole/CompletionModel.h PRE-CREATION
> src/scripting/scriptconsole/CompletionModel.cpp PRE-CREATION
> src/scripting/scriptconsole/ScriptConsole.h PRE-CREATION
> src/scripting/scriptconsole/ScriptConsole.cpp PRE-CREATION
> src/scripting/scriptconsole/ScriptConsoleItem.h PRE-CREATION
> src/scripting/scriptconsole/ScriptConsoleItem.cpp PRE-CREATION
> src/scripting/scriptconsole/ScriptEditorDocument.h PRE-CREATION
> src/scripting/scriptconsole/ScriptEditorDocument.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/113387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anmol Ahuja
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113387/">http://git.reviewboard.kde.org/r/113387/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113387/diff/1/?file=204517#file204517line108" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scripting/scriptconsole/ScriptConsole.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">108</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> class DebuggerProxyAgent : public QScriptEngineAgent</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this \
class commented out? Never keep commented out code, unless there is a very good \
reason to, and also an extra comment explaining why it is there.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113387/diff/1/?file=204518#file204518line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scripting/scriptconsole/ScriptConsole.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">118</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="cm">/* action = new KAction( i18n("Previous Script"), this \
);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove \
commented out code.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113387/diff/1/?file=204518#file204518line174" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scripting/scriptconsole/ScriptConsole.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">174</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">ScriptConsole</span><span class="o">::</span><span \
class="n">slotExecuteNewScript</span><span class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
clean up this function.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113387/diff/1/?file=204518#file204518line293" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scripting/scriptconsole/ScriptConsole.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">293</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//new DebuggerProxyAgent( item->engine() );</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove \
commented out code.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113387/diff/1/?file=204518#file204518line341" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/scripting/scriptconsole/ScriptConsole.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">341</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// new HorizontalDivider( widget );</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove \
commented out code.</pre> </div>
<br />
<p>- Mark Kretschmann</p>
<br />
<p>On October 22nd, 2013, 4:06 p.m. UTC, Anmol Ahuja wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 4:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The new script console.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/scripting/scriptconsole/CompletionModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/CompletionModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsole.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsole.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsoleItem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptConsoleItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptEditorDocument.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scripting/scriptconsole/ScriptEditorDocument.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113387/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic