--===============3741737314802429618==
Content-Type: multipart/alternative;
 boundary="===============8573610471571742102=="

--===============8573610471571742102==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113384/#review43805
-----------------------------------------------------------



src/scriptengine/AmarokBookmarkScript.h
<http://git.reviewboard.kde.org/r/113384/#comment31447>

    I think it is confusing to abuse the "slots" keyword like this. Is there an alternative? Or at least a comment should be added.


- Mark Kretschmann


On Oct. 22, 2013, 4:07 p.m., Anmol Ahuja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113384/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 4:07 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> -------
> 
> The scripting wrappers written as part of my project.
> 
> 
> Diffs
> -----
> 
>   src/scriptengine/AmarokPlaylistManagerScript.h PRE-CREATION 
>   src/scriptengine/AmarokOSDScript.cpp 659cd68 
>   src/scriptengine/AmarokOSDScript.h 992fcee 
>   src/scriptengine/AmarokNetworkScript.cpp 0eaa440 
>   src/scriptengine/AmarokLyricsScript.cpp b1972fa 
>   src/scriptengine/AmarokNetworkScript.h 785a645 
>   src/scriptengine/AmarokLyricsScript.h a47c609 
>   src/scriptengine/AmarokKNotifyScript.cpp b98efed 
>   src/scriptengine/AmarokKNotifyScript.h 720f9f6 
>   src/scriptengine/AmarokInfoScript.cpp 4d06568 
>   src/scriptengine/AmarokEqualizerScript.cpp PRE-CREATION 
>   src/scriptengine/AmarokInfoScript.h 754498e 
>   src/scriptengine/AmarokEqualizerScript.h PRE-CREATION 
>   src/scriptengine/AmarokEngineScript.cpp 5471838 
>   src/scriptengine/AmarokEngineScript.h aa2b112 
>   src/scriptengine/AmarokCollectionViewScript.cpp PRE-CREATION 
>   src/scriptengine/AmarokCollectionViewScript.h PRE-CREATION 
>   src/scriptengine/AmarokCollectionScript.cpp 3fcda84 
>   src/scriptengine/AmarokBookmarkScript.cpp PRE-CREATION 
>   src/scriptengine/AmarokCollectionScript.h 224bd54 
>   src/scriptengine/AmarokBookmarkScript.h PRE-CREATION 
>   src/scriptengine/AmarokPlaylistManagerScript.cpp PRE-CREATION 
>   src/scriptengine/AmarokPlaylistScript.h a9df74e 
>   src/scriptengine/AmarokPlaylistScript.cpp 2dde634 
>   src/scriptengine/AmarokScript.h 4ec6d8f 
>   src/scriptengine/AmarokScript.cpp b21a2ec 
>   src/scriptengine/AmarokScriptConfig.h a77418f 
>   src/scriptengine/AmarokScriptConfig.cpp 457104a 
>   src/scriptengine/AmarokScriptableServiceScript.h 6afacfa 
>   src/scriptengine/AmarokScriptableServiceScript.cpp a312671 
>   src/scriptengine/AmarokServicePluginManagerScript.h ed7f307 
>   src/scriptengine/AmarokServicePluginManagerScript.cpp 86f841c 
>   src/scriptengine/AmarokStatusbarScript.h c871213 
>   src/scriptengine/AmarokStatusbarScript.cpp 6efbb38 
>   src/scriptengine/AmarokStreamItemScript.h PRE-CREATION 
>   src/scriptengine/AmarokStreamItemScript.cpp PRE-CREATION 
>   src/scriptengine/AmarokWindowScript.h 5b18e18 
>   src/scriptengine/AmarokWindowScript.cpp c9a65ee 
>   src/scriptengine/MetaTypeExporter.h ec961e8 
>   src/scriptengine/MetaTypeExporter.cpp d832181 
>   src/scriptengine/PHAACG2.py PRE-CREATION 
>   src/scriptengine/ScriptImporter.h 7ae9155 
>   src/scriptengine/ScriptImporter.cpp 672cd24 
>   src/scriptengine/ScriptingDefines.h PRE-CREATION 
>   src/scriptengine/ScriptingDefines.cpp PRE-CREATION 
>   src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION 
>   src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION 
>   src/scriptengine/exporters/PlaylistExporter.h PRE-CREATION 
>   src/scriptengine/exporters/PlaylistExporter.cpp PRE-CREATION 
>   src/scriptengine/exporters/PlaylistProviderExporter.h PRE-CREATION 
>   src/scriptengine/exporters/PlaylistProviderExporter.cpp PRE-CREATION 
>   src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION 
>   src/scriptengine/exporters/QueryMakerExporter.cpp PRE-CREATION 
>   src/scriptengine/exporters/ScriptableBiasExporter.h PRE-CREATION 
>   src/scriptengine/exporters/ScriptableBiasExporter.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anmol Ahuja
> 
>


--===============8573610471571742102==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113384/">http://git.reviewboard.kde.org/r/113384/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/113384/diff/1/?file=204397#file204397line44" style="color: black; font-weight: bold; text-decoration: underline;">src/scriptengine/AmarokBookmarkScript.h</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="n">public</span> <span class="n">slots</span><span class="o">:</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it is confusing to abuse the &quot;slots&quot; keyword like this. Is there an alternative? Or at least a comment should be added.</pre>
</div>
<br />



<p>- Mark Kretschmann</p>


<br />
<p>On October 22nd, 2013, 4:07 p.m. UTC, Anmol Ahuja wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>


<p style="color: grey;"><i>Updated Oct. 22, 2013, 4:07 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The scripting wrappers written as part of my project.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/scriptengine/AmarokPlaylistManagerScript.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokOSDScript.cpp <span style="color: grey">(659cd68)</span></li>

 <li>src/scriptengine/AmarokOSDScript.h <span style="color: grey">(992fcee)</span></li>

 <li>src/scriptengine/AmarokNetworkScript.cpp <span style="color: grey">(0eaa440)</span></li>

 <li>src/scriptengine/AmarokLyricsScript.cpp <span style="color: grey">(b1972fa)</span></li>

 <li>src/scriptengine/AmarokNetworkScript.h <span style="color: grey">(785a645)</span></li>

 <li>src/scriptengine/AmarokLyricsScript.h <span style="color: grey">(a47c609)</span></li>

 <li>src/scriptengine/AmarokKNotifyScript.cpp <span style="color: grey">(b98efed)</span></li>

 <li>src/scriptengine/AmarokKNotifyScript.h <span style="color: grey">(720f9f6)</span></li>

 <li>src/scriptengine/AmarokInfoScript.cpp <span style="color: grey">(4d06568)</span></li>

 <li>src/scriptengine/AmarokEqualizerScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokInfoScript.h <span style="color: grey">(754498e)</span></li>

 <li>src/scriptengine/AmarokEqualizerScript.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokEngineScript.cpp <span style="color: grey">(5471838)</span></li>

 <li>src/scriptengine/AmarokEngineScript.h <span style="color: grey">(aa2b112)</span></li>

 <li>src/scriptengine/AmarokCollectionViewScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokCollectionViewScript.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokCollectionScript.cpp <span style="color: grey">(3fcda84)</span></li>

 <li>src/scriptengine/AmarokBookmarkScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokCollectionScript.h <span style="color: grey">(224bd54)</span></li>

 <li>src/scriptengine/AmarokBookmarkScript.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokPlaylistManagerScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokPlaylistScript.h <span style="color: grey">(a9df74e)</span></li>

 <li>src/scriptengine/AmarokPlaylistScript.cpp <span style="color: grey">(2dde634)</span></li>

 <li>src/scriptengine/AmarokScript.h <span style="color: grey">(4ec6d8f)</span></li>

 <li>src/scriptengine/AmarokScript.cpp <span style="color: grey">(b21a2ec)</span></li>

 <li>src/scriptengine/AmarokScriptConfig.h <span style="color: grey">(a77418f)</span></li>

 <li>src/scriptengine/AmarokScriptConfig.cpp <span style="color: grey">(457104a)</span></li>

 <li>src/scriptengine/AmarokScriptableServiceScript.h <span style="color: grey">(6afacfa)</span></li>

 <li>src/scriptengine/AmarokScriptableServiceScript.cpp <span style="color: grey">(a312671)</span></li>

 <li>src/scriptengine/AmarokServicePluginManagerScript.h <span style="color: grey">(ed7f307)</span></li>

 <li>src/scriptengine/AmarokServicePluginManagerScript.cpp <span style="color: grey">(86f841c)</span></li>

 <li>src/scriptengine/AmarokStatusbarScript.h <span style="color: grey">(c871213)</span></li>

 <li>src/scriptengine/AmarokStatusbarScript.cpp <span style="color: grey">(6efbb38)</span></li>

 <li>src/scriptengine/AmarokStreamItemScript.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokStreamItemScript.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/AmarokWindowScript.h <span style="color: grey">(5b18e18)</span></li>

 <li>src/scriptengine/AmarokWindowScript.cpp <span style="color: grey">(c9a65ee)</span></li>

 <li>src/scriptengine/MetaTypeExporter.h <span style="color: grey">(ec961e8)</span></li>

 <li>src/scriptengine/MetaTypeExporter.cpp <span style="color: grey">(d832181)</span></li>

 <li>src/scriptengine/PHAACG2.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/ScriptImporter.h <span style="color: grey">(7ae9155)</span></li>

 <li>src/scriptengine/ScriptImporter.cpp <span style="color: grey">(672cd24)</span></li>

 <li>src/scriptengine/ScriptingDefines.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/ScriptingDefines.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/CollectionTypeExporter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/CollectionTypeExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/PlaylistExporter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/PlaylistExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/PlaylistProviderExporter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/PlaylistProviderExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/QueryMakerExporter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/QueryMakerExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/ScriptableBiasExporter.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/scriptengine/exporters/ScriptableBiasExporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113384/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============8573610471571742102==--

--===============3741737314802429618==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

--===============3741737314802429618==--