[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Review Request 113876: Linking error in newly created files
From: "Vedant Agarwala" <vedant.kota () gmail ! com>
Date: 2013-11-15 9:54:05
Message-ID: 20131115095405.15533.25927 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113876/
-----------------------------------------------------------
Review request for Amarok.
Repository: amarok
Description
-------
I am stuck at this undefined reference errors: http://pastebin.kde.org/pcb6qgj78
Basically the MusicBrainzFiner class inherits the TagGuessing::Provider class. I \
tried to create a new Tagguessing library but it would always lead to "cyclic \
dependencies" in CMake. Finally I added all the tagguessing classes (i.e. the classes \
in dir "tagguessing" and its sub dirs) to amaroklib. Even then I am getting the \
linking errors. I added the AMAROK_EXPORT macro to these classes but still the same \
error was being produced so I reverted.
Diffs
-----
src/tagguessing/acustid/Webservicequeryer.cpp PRE-CREATION
src/tagguessing/musicbrainz/CMakeLists.txt PRE-CREATION
src/tagguessing/musicbrainz/MusicBrainzFinder.h PRE-CREATION
src/tagguessing/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION
src/tagguessing/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION
src/tagguessing/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION
src/tagguessing/musicbrainz/MusicDNSFinder.h PRE-CREATION
src/tagguessing/musicbrainz/MusicDNSFinder.cpp PRE-CREATION
src/tagguessing/musicbrainz/MusicDNSXmlParser.h PRE-CREATION
src/tagguessing/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION
CMakeLists.txt 4ffee3a
ChangeLog ad84f5b
cmake/modules/FindLibChromaprint.cmake PRE-CREATION
src/CMakeLists.txt 70fb67b
src/context/applets/analyzer/BlockAnalyzer.h df0506b
src/context/applets/analyzer/BlockAnalyzer.cpp 6325774
src/dialogs/MusicBrainzTagger.h bef0621
src/dialogs/MusicBrainzTagger.cpp 591f087
src/dialogs/MusicBrainzTagger.ui 156f8d3
src/dialogs/OrganizeCollectionDialog.h 88fa08d
src/dialogs/OrganizeCollectionDialog.cpp 1c14710
src/dialogs/OrganizeCollectionDialogBase.ui 85d0ec8
src/dialogs/TagDialog.h 626f903
src/dialogs/TagDialog.cpp 48aadd9
src/dialogs/TagDialogBase.ui 7ed36ea
src/dialogs/WebServicesTagger.h PRE-CREATION
src/dialogs/WebServicesTagger.cpp PRE-CREATION
src/dialogs/WebServicesTagger.ui PRE-CREATION
src/musicbrainz/MusicBrainzFinder.h beb1551
src/musicbrainz/MusicBrainzFinder.cpp 9a1b3bb
src/musicbrainz/MusicBrainzMeta.h 6e21232
src/musicbrainz/MusicBrainzTagsItem.h 6852c9f
src/musicbrainz/MusicBrainzTagsItem.cpp 0941a90
src/musicbrainz/MusicBrainzTagsModel.h eaee7f8
src/musicbrainz/MusicBrainzTagsModel.cpp 0ffb284
src/musicbrainz/MusicBrainzTagsModelDelegate.h d276af7
src/musicbrainz/MusicBrainzTagsModelDelegate.cpp a11c9c3
src/musicbrainz/MusicBrainzTagsView.h 6997e34
src/musicbrainz/MusicBrainzTagsView.cpp 96cbd17
src/musicbrainz/MusicBrainzXmlParser.h c7f9e72
src/musicbrainz/MusicBrainzXmlParser.cpp 290a275
src/musicbrainz/MusicDNSAudioDecoder.h ca98c20
src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b
src/musicbrainz/MusicDNSFinder.h 90c4c9c
src/musicbrainz/MusicDNSFinder.cpp d393211
src/musicbrainz/MusicDNSXmlParser.h 982861d
src/musicbrainz/MusicDNSXmlParser.cpp 1f3f54f
src/tagguessing/AudioToQStringDecoder.h PRE-CREATION
src/tagguessing/AudioToQStringDecoder.cpp PRE-CREATION
src/tagguessing/CMakeLists.txt PRE-CREATION
src/tagguessing/Finder.h PRE-CREATION
src/tagguessing/Finder.cpp PRE-CREATION
src/tagguessing/Meta.h PRE-CREATION
src/tagguessing/Provider.h PRE-CREATION
src/tagguessing/Provider.cpp PRE-CREATION
src/tagguessing/TagsItem.h PRE-CREATION
src/tagguessing/TagsItem.cpp PRE-CREATION
src/tagguessing/TagsModel.h PRE-CREATION
src/tagguessing/TagsModel.cpp PRE-CREATION
src/tagguessing/TagsModelDelegate.h PRE-CREATION
src/tagguessing/TagsModelDelegate.cpp PRE-CREATION
src/tagguessing/TagsView.h PRE-CREATION
src/tagguessing/TagsView.cpp PRE-CREATION
src/tagguessing/WebRequestsHandler.h PRE-CREATION
src/tagguessing/WebRequestsHandler.cpp PRE-CREATION
src/tagguessing/acustid/Acustidprovider.h PRE-CREATION
src/tagguessing/acustid/Acustidprovider.cpp PRE-CREATION
src/tagguessing/acustid/CMakeLists.txt PRE-CREATION
src/tagguessing/acustid/Fingerprintcalculator.h PRE-CREATION
src/tagguessing/acustid/Fingerprintcalculator.cpp PRE-CREATION
src/tagguessing/acustid/Webservicequeryer.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/113876/diff/
Testing
-------
Thanks,
Vedant Agarwala
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113876/">http://git.reviewboard.kde.org/r/113876/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Vedant Agarwala.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I am stuck at this undefined reference errors: \
http://pastebin.kde.org/pcb6qgj78 Basically the MusicBrainzFiner class inherits the \
TagGuessing::Provider class. I tried to create a new Tagguessing library but it would \
always lead to "cyclic dependencies" in CMake. Finally I added all the \
tagguessing classes (i.e. the classes in dir "tagguessing" and its sub \
dirs) to amaroklib. Even then I am getting the linking errors. I added the \
AMAROK_EXPORT macro to these classes but still the same error was being produced so I \
reverted.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/tagguessing/acustid/Webservicequeryer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzFinder.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzFinder.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzXmlParser.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicBrainzXmlParser.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSFinder.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSFinder.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSXmlParser.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/musicbrainz/MusicDNSXmlParser.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(4ffee3a)</span></li>
<li>ChangeLog <span style="color: grey">(ad84f5b)</span></li>
<li>cmake/modules/FindLibChromaprint.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(70fb67b)</span></li>
<li>src/context/applets/analyzer/BlockAnalyzer.h <span style="color: \
grey">(df0506b)</span></li>
<li>src/context/applets/analyzer/BlockAnalyzer.cpp <span style="color: \
grey">(6325774)</span></li>
<li>src/dialogs/MusicBrainzTagger.h <span style="color: grey">(bef0621)</span></li>
<li>src/dialogs/MusicBrainzTagger.cpp <span style="color: \
grey">(591f087)</span></li>
<li>src/dialogs/MusicBrainzTagger.ui <span style="color: grey">(156f8d3)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.h <span style="color: \
grey">(88fa08d)</span></li>
<li>src/dialogs/OrganizeCollectionDialog.cpp <span style="color: \
grey">(1c14710)</span></li>
<li>src/dialogs/OrganizeCollectionDialogBase.ui <span style="color: \
grey">(85d0ec8)</span></li>
<li>src/dialogs/TagDialog.h <span style="color: grey">(626f903)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey">(48aadd9)</span></li>
<li>src/dialogs/TagDialogBase.ui <span style="color: grey">(7ed36ea)</span></li>
<li>src/dialogs/WebServicesTagger.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/dialogs/WebServicesTagger.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/dialogs/WebServicesTagger.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.h <span style="color: \
grey">(beb1551)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: \
grey">(9a1b3bb)</span></li>
<li>src/musicbrainz/MusicBrainzMeta.h <span style="color: \
grey">(6e21232)</span></li>
<li>src/musicbrainz/MusicBrainzTagsItem.h <span style="color: \
grey">(6852c9f)</span></li>
<li>src/musicbrainz/MusicBrainzTagsItem.cpp <span style="color: \
grey">(0941a90)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.h <span style="color: \
grey">(eaee7f8)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModel.cpp <span style="color: \
grey">(0ffb284)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModelDelegate.h <span style="color: \
grey">(d276af7)</span></li>
<li>src/musicbrainz/MusicBrainzTagsModelDelegate.cpp <span style="color: \
grey">(a11c9c3)</span></li>
<li>src/musicbrainz/MusicBrainzTagsView.h <span style="color: \
grey">(6997e34)</span></li>
<li>src/musicbrainz/MusicBrainzTagsView.cpp <span style="color: \
grey">(96cbd17)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.h <span style="color: \
grey">(c7f9e72)</span></li>
<li>src/musicbrainz/MusicBrainzXmlParser.cpp <span style="color: \
grey">(290a275)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.h <span style="color: \
grey">(ca98c20)</span></li>
<li>src/musicbrainz/MusicDNSAudioDecoder.cpp <span style="color: \
grey">(ea39a1b)</span></li>
<li>src/musicbrainz/MusicDNSFinder.h <span style="color: grey">(90c4c9c)</span></li>
<li>src/musicbrainz/MusicDNSFinder.cpp <span style="color: \
grey">(d393211)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.h <span style="color: \
grey">(982861d)</span></li>
<li>src/musicbrainz/MusicDNSXmlParser.cpp <span style="color: \
grey">(1f3f54f)</span></li>
<li>src/tagguessing/AudioToQStringDecoder.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/AudioToQStringDecoder.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Finder.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Finder.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Meta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Provider.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/Provider.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsItem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModelDelegate.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsModelDelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsView.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/TagsView.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/WebRequestsHandler.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/WebRequestsHandler.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acustid/Acustidprovider.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acustid/Acustidprovider.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acustid/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acustid/Fingerprintcalculator.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acustid/Fingerprintcalculator.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/tagguessing/acustid/Webservicequeryer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113876/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic