[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Review Request 113390: GSoC 2013 Revamping Scripting - Part 6/6 : Misc src/
From: "Anmol Ahuja" <darthcodus () gmail ! com>
Date: 2013-10-22 16:06:42
Message-ID: 20131022160642.27918.30550 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113390/
-----------------------------------------------------------
Review request for Amarok.
Repository: amarok
Description
-------
Miscellaneous changes made in the src/ folder.
Diffs
-----
src/App.h 9ee071d
src/App.cpp eb3f483
src/CMakeLists.txt 70fb67b
src/EngineController.h 80ec17b
src/EngineController.cpp cf29cf8
src/amarokconfig.kcfg 84cfa5b
src/amarokurls/BookmarkGroup.h ea42c30
src/browsers/CollectionTreeItem.h 0a5d197
src/browsers/CollectionTreeItem.cpp 4c35523
src/browsers/CollectionTreeItemModelBase.h 00e99fb
src/browsers/CollectionTreeView.h 454a70d
src/browsers/CollectionTreeView.cpp 6fad164
src/browsers/collectionbrowser/CollectionWidget.h 7480015
src/browsers/collectionbrowser/CollectionWidget.cpp 95a16dc
src/configdialog/dialogs/ScriptSelector.h 9ce1168
src/configdialog/dialogs/ScriptSelector.cpp 117cedf
src/configdialog/dialogs/ScriptsConfig.h 6a47847
src/configdialog/dialogs/ScriptsConfig.cpp 714b63e
src/configdialog/dialogs/ScriptsConfig.ui b4b8d37
src/context/applets/lyrics/LyricsApplet.cpp 7db356d
src/context/applets/songkick/SongkickApplet.cpp ed93e56
src/context/engines/lyrics/LyricsEngine.cpp d3273b0
src/core-impl/collections/support/jobs/WriteTagsJob.h a92ab8d
src/core-impl/collections/support/jobs/WriteTagsJob.cpp 5834cd4
src/core/collections/Collection.h 94d24d7
src/core/collections/QueryMaker.h 92b6a65
src/core/meta/support/MetaConstants.cpp 40d7122
src/dialogs/DiagnosticDialog.cpp c9bfce6
src/dialogs/EqualizerDialog.h 6c9e19e
src/dialogs/EqualizerDialog.cpp acf0da0
src/dialogs/deviceconfiguredialog.cpp e54edad
src/dynamic/BiasFactory.cpp 2a887c2
src/dynamic/TrackSet.h dee8ee3
src/dynamic/TrackSet.cpp 456a10a
src/equalizer/EqualizerPresets.h be8d267
src/equalizer/EqualizerPresets.cpp b9aa13b
src/playback/EqualizerController.h PRE-CREATION
src/playback/EqualizerController.cpp PRE-CREATION
src/playlistmanager/PlaylistManager.h a835c35
src/services/scriptable/ScriptableService.cpp f254e3e
src/services/scriptable/ScriptableServiceInfoParser.cpp 998135b
src/services/scriptable/ScriptableServiceManager.cpp aa28a6c
src/services/scriptable/ScriptableServiceQueryMaker.cpp 07233dd
Diff: http://git.reviewboard.kde.org/r/113390/diff/
Testing
-------
Thanks,
Anmol Ahuja
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113390/">http://git.reviewboard.kde.org/r/113390/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Anmol Ahuja.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Miscellaneous changes made in the src/ folder.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/App.h <span style="color: grey">(9ee071d)</span></li>
<li>src/App.cpp <span style="color: grey">(eb3f483)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(70fb67b)</span></li>
<li>src/EngineController.h <span style="color: grey">(80ec17b)</span></li>
<li>src/EngineController.cpp <span style="color: grey">(cf29cf8)</span></li>
<li>src/amarokconfig.kcfg <span style="color: grey">(84cfa5b)</span></li>
<li>src/amarokurls/BookmarkGroup.h <span style="color: grey">(ea42c30)</span></li>
<li>src/browsers/CollectionTreeItem.h <span style="color: \
grey">(0a5d197)</span></li>
<li>src/browsers/CollectionTreeItem.cpp <span style="color: \
grey">(4c35523)</span></li>
<li>src/browsers/CollectionTreeItemModelBase.h <span style="color: \
grey">(00e99fb)</span></li>
<li>src/browsers/CollectionTreeView.h <span style="color: \
grey">(454a70d)</span></li>
<li>src/browsers/CollectionTreeView.cpp <span style="color: \
grey">(6fad164)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.h <span style="color: \
grey">(7480015)</span></li>
<li>src/browsers/collectionbrowser/CollectionWidget.cpp <span style="color: \
grey">(95a16dc)</span></li>
<li>src/configdialog/dialogs/ScriptSelector.h <span style="color: \
grey">(9ce1168)</span></li>
<li>src/configdialog/dialogs/ScriptSelector.cpp <span style="color: \
grey">(117cedf)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.h <span style="color: \
grey">(6a47847)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.cpp <span style="color: \
grey">(714b63e)</span></li>
<li>src/configdialog/dialogs/ScriptsConfig.ui <span style="color: \
grey">(b4b8d37)</span></li>
<li>src/context/applets/lyrics/LyricsApplet.cpp <span style="color: \
grey">(7db356d)</span></li>
<li>src/context/applets/songkick/SongkickApplet.cpp <span style="color: \
grey">(ed93e56)</span></li>
<li>src/context/engines/lyrics/LyricsEngine.cpp <span style="color: \
grey">(d3273b0)</span></li>
<li>src/core-impl/collections/support/jobs/WriteTagsJob.h <span style="color: \
grey">(a92ab8d)</span></li>
<li>src/core-impl/collections/support/jobs/WriteTagsJob.cpp <span style="color: \
grey">(5834cd4)</span></li>
<li>src/core/collections/Collection.h <span style="color: \
grey">(94d24d7)</span></li>
<li>src/core/collections/QueryMaker.h <span style="color: \
grey">(92b6a65)</span></li>
<li>src/core/meta/support/MetaConstants.cpp <span style="color: \
grey">(40d7122)</span></li>
<li>src/dialogs/DiagnosticDialog.cpp <span style="color: grey">(c9bfce6)</span></li>
<li>src/dialogs/EqualizerDialog.h <span style="color: grey">(6c9e19e)</span></li>
<li>src/dialogs/EqualizerDialog.cpp <span style="color: grey">(acf0da0)</span></li>
<li>src/dialogs/deviceconfiguredialog.cpp <span style="color: \
grey">(e54edad)</span></li>
<li>src/dynamic/BiasFactory.cpp <span style="color: grey">(2a887c2)</span></li>
<li>src/dynamic/TrackSet.h <span style="color: grey">(dee8ee3)</span></li>
<li>src/dynamic/TrackSet.cpp <span style="color: grey">(456a10a)</span></li>
<li>src/equalizer/EqualizerPresets.h <span style="color: grey">(be8d267)</span></li>
<li>src/equalizer/EqualizerPresets.cpp <span style="color: \
grey">(b9aa13b)</span></li>
<li>src/playback/EqualizerController.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playback/EqualizerController.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/playlistmanager/PlaylistManager.h <span style="color: \
grey">(a835c35)</span></li>
<li>src/services/scriptable/ScriptableService.cpp <span style="color: \
grey">(f254e3e)</span></li>
<li>src/services/scriptable/ScriptableServiceInfoParser.cpp <span style="color: \
grey">(998135b)</span></li>
<li>src/services/scriptable/ScriptableServiceManager.cpp <span style="color: \
grey">(aa28a6c)</span></li>
<li>src/services/scriptable/ScriptableServiceQueryMaker.cpp <span style="color: \
grey">(07233dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113390/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic