'Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 112221: 313504: Prefer QChar overloads over the QString ones for efficiency (left
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2013-08-25 8:45:57
Message-ID: 20130825084557.3208.20070 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112221/
-----------------------------------------------------------

(Updated Aug. 25, 2013, 8:45 a.m.)

Status
------

This change has been marked as submitted.

Review request for Amarok.

Description
-------

Fix the few remaining cases i missed on the first run. See: https://git.reviewboard.kde.org/r/112148/

This addresses bug 313504.
    https://bugs.kde.org/show_bug.cgi?id=313504

Diffs
-----

  src/core-impl/collections/umscollection/UmsCollection.cpp ad38461 
  src/dialogs/DiagnosticDialog.cpp a5f2e17 
  tests/synchronization/TestOneWaySynchronizationJob.cpp e7829b4 

Diff: http://git.reviewboard.kde.org/r/112221/diff/

Testing
-------

unit tests pass.

Thanks,

Frank Meerkoetter

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112221/">http://git.reviewboard.kde.org/r/112221/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Frank Meerkoetter.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2013, 8:45 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix the few remaining cases i missed on the first run. See: \
https://git.reviewboard.kde.org/r/112148/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">unit tests pass.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=313504">313504</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core-impl/collections/umscollection/UmsCollection.cpp <span style="color: \
grey">(ad38461)</span></li>

 <li>src/dialogs/DiagnosticDialog.cpp <span style="color: grey">(a5f2e17)</span></li>

 <li>tests/synchronization/TestOneWaySynchronizationJob.cpp <span style="color: \
grey">(e7829b4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112221/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 