[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Review Request 111552: Week 4 : Revamping Amarok's Scripting Interface
From: "Anmol Ahuja" <darthcodus () gmail ! com>
Date: 2013-07-17 16:49:19
Message-ID: 20130717164919.28025.9485 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111552/
-----------------------------------------------------------
Review request for Amarok and Mark Kretschmann.
Description
-------
Kinda messy, not even sure if it's builds. Everything will be cleaned by the next \
week, including the existing API.
Diffs
-----
src/CMakeLists.txt 69a8ff4
src/scriptconsole/CompletionModel.h PRE-CREATION
src/scriptconsole/CompletionModel.cpp PRE-CREATION
src/scriptconsole/ScriptConsole.h PRE-CREATION
src/scriptconsole/ScriptConsole.cpp PRE-CREATION
src/scriptconsole/ScriptConsole.ui PRE-CREATION
src/scriptconsole/ScriptConsoleItem.h PRE-CREATION
src/scriptconsole/ScriptConsoleItem.cpp PRE-CREATION
src/scriptconsole/ScriptEditorDocument.cpp PRE-CREATION
src/scriptconsole/ScriptItemDelegate.cpp PRE-CREATION
src/scriptengine/AmarokCollectionScript.h 5733947
src/scriptengine/AmarokCollectionScript.cpp 3fcda84
src/scriptengine/AmarokEngineScript.h aa2b112
src/scriptengine/AmarokEngineScript.cpp 5471838
src/scriptengine/AmarokInfoScript.h 754498e
src/scriptengine/AmarokInfoScript.cpp 4d06568
src/scriptengine/AmarokKNotifyScript.h 720f9f6
src/scriptengine/AmarokKNotifyScript.cpp b98efed
src/scriptengine/AmarokLyricsScript.h a47c609
src/scriptengine/AmarokNetworkScript.h 0af0f9b
src/scriptengine/AmarokNetworkScript.cpp 0eaa440
src/scriptengine/AmarokOSDScript.h 992fcee
src/scriptengine/AmarokOSDScript.cpp 659cd68
src/scriptengine/AmarokPlaylistScript.h 28f9d7e
src/scriptengine/AmarokScript.h 891927d
src/scriptengine/AmarokScriptConfig.h 2f72890
src/scriptengine/AmarokScriptConfig.cpp 457104a
src/scriptengine/AmarokScriptableServiceScript.h 6dbe4b5
src/scriptengine/AmarokScriptableServiceScript.cpp a312671
src/scriptengine/AmarokServicePluginManagerScript.h 6851dc7
src/scriptengine/AmarokStatusbarScript.h c871213
src/scriptengine/AmarokStreamItemScript.h PRE-CREATION
src/scriptengine/AmarokStreamItemScript.cpp PRE-CREATION
src/scriptengine/AmarokWindowScript.h 5b18e18
src/scriptengine/PHAACG2.py PRE-CREATION
src/scriptengine/ScriptImporter.h 7de9a4c
src/scriptengine/ScriptingDefines.h PRE-CREATION
src/scriptengine/ScriptingDefines.cpp PRE-CREATION
src/scriptengine/exporters/CollectionTypeExporter.h PRE-CREATION
src/scriptengine/exporters/CollectionTypeExporter.cpp PRE-CREATION
src/scriptengine/exporters/MetaTypeExporter.h PRE-CREATION
src/scriptengine/exporters/QueryMakerExporter.h PRE-CREATION
src/scriptmanager/ScriptItem.h PRE-CREATION
src/scriptmanager/ScriptItem.cpp PRE-CREATION
src/scriptmanager/ScriptManager.h PRE-CREATION
src/scriptmanager/ScriptManager.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111552/diff/
Testing
-------
Thanks,
Anmol Ahuja
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111552/">http://git.reviewboard.kde.org/r/111552/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok and Mark Kretschmann.</div>
<div>By Anmol Ahuja.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kinda messy, not even sure if it's builds. Everything will be \
cleaned by the next week, including the existing API.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(69a8ff4)</span></li>
<li>src/scriptconsole/CompletionModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/CompletionModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptConsole.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptConsole.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptConsole.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptConsoleItem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptConsoleItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptEditorDocument.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptconsole/ScriptItemDelegate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/AmarokCollectionScript.h <span style="color: \
grey">(5733947)</span></li>
<li>src/scriptengine/AmarokCollectionScript.cpp <span style="color: \
grey">(3fcda84)</span></li>
<li>src/scriptengine/AmarokEngineScript.h <span style="color: \
grey">(aa2b112)</span></li>
<li>src/scriptengine/AmarokEngineScript.cpp <span style="color: \
grey">(5471838)</span></li>
<li>src/scriptengine/AmarokInfoScript.h <span style="color: \
grey">(754498e)</span></li>
<li>src/scriptengine/AmarokInfoScript.cpp <span style="color: \
grey">(4d06568)</span></li>
<li>src/scriptengine/AmarokKNotifyScript.h <span style="color: \
grey">(720f9f6)</span></li>
<li>src/scriptengine/AmarokKNotifyScript.cpp <span style="color: \
grey">(b98efed)</span></li>
<li>src/scriptengine/AmarokLyricsScript.h <span style="color: \
grey">(a47c609)</span></li>
<li>src/scriptengine/AmarokNetworkScript.h <span style="color: \
grey">(0af0f9b)</span></li>
<li>src/scriptengine/AmarokNetworkScript.cpp <span style="color: \
grey">(0eaa440)</span></li>
<li>src/scriptengine/AmarokOSDScript.h <span style="color: \
grey">(992fcee)</span></li>
<li>src/scriptengine/AmarokOSDScript.cpp <span style="color: \
grey">(659cd68)</span></li>
<li>src/scriptengine/AmarokPlaylistScript.h <span style="color: \
grey">(28f9d7e)</span></li>
<li>src/scriptengine/AmarokScript.h <span style="color: grey">(891927d)</span></li>
<li>src/scriptengine/AmarokScriptConfig.h <span style="color: \
grey">(2f72890)</span></li>
<li>src/scriptengine/AmarokScriptConfig.cpp <span style="color: \
grey">(457104a)</span></li>
<li>src/scriptengine/AmarokScriptableServiceScript.h <span style="color: \
grey">(6dbe4b5)</span></li>
<li>src/scriptengine/AmarokScriptableServiceScript.cpp <span style="color: \
grey">(a312671)</span></li>
<li>src/scriptengine/AmarokServicePluginManagerScript.h <span style="color: \
grey">(6851dc7)</span></li>
<li>src/scriptengine/AmarokStatusbarScript.h <span style="color: \
grey">(c871213)</span></li>
<li>src/scriptengine/AmarokStreamItemScript.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/AmarokStreamItemScript.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/AmarokWindowScript.h <span style="color: \
grey">(5b18e18)</span></li>
<li>src/scriptengine/PHAACG2.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/ScriptImporter.h <span style="color: \
grey">(7de9a4c)</span></li>
<li>src/scriptengine/ScriptingDefines.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/ScriptingDefines.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/CollectionTypeExporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/CollectionTypeExporter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/MetaTypeExporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptengine/exporters/QueryMakerExporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptmanager/ScriptItem.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptmanager/ScriptItem.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptmanager/ScriptManager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/scriptmanager/ScriptManager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111552/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic