'Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 111510: Consistently use FindFFMpeg.cmake from kdelibs
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2013-07-16 7:45:50
Message-ID: 20130716074550.29459.36256 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111510/#review36018
-----------------------------------------------------------

Ship it!

Ship It!

- Mark Kretschmann

On July 15, 2013, 1:18 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111510/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 1:18 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Consistently use FindFFMpeg.cmake from kdelibs
> 
> FindFFMpeg from kdelibs works differently to our internal one (and, in
> fact, more consistently with standard Find* files).  Since we depends on
> kdelibs anyway, we now just use the kdelibs one and don't bother
> shipping our own.
> 
> 
> Diffs
> -----
> 
> ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c 
> cmake/modules/FindFFmpeg.cmake 0aa2cdc33a88953fe8b94532cb45c43ad35e0da8 
> src/CMakeLists.txt 589fddb9ea2177102cabd3a193a9e6848ea9c12d 
> 
> Diff: http://git.reviewboard.kde.org/r/111510/diff/
> 
> 
> Testing
> -------
> 
> Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5.  No other \
> configurations tested.  (Without the patch, the build fails with this \
> configuration). 
> 
> Thanks,
> 
> Alex Merry
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111510/">http://git.reviewboard.kde.org/r/111510/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Mark</p>

<br />
<p>On July 15th, 2013, 1:18 p.m. UTC, Alex Merry wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated July 15, 2013, 1:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Consistently use FindFFMpeg.cmake from kdelibs

FindFFMpeg from kdelibs works differently to our internal one (and, in
fact, more consistently with standard Find* files).  Since we depends on
kdelibs anyway, we now just use the kdelibs one and don&#39;t bother
shipping our own.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5.  No \
other configurations tested.  (Without the patch, the build fails with this \
configuration).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ChangeLog <span style="color: \
grey">(5fe5d2e64c771d722f3f90bf6c98d5013e56553c)</span></li>

 <li>cmake/modules/FindFFmpeg.cmake <span style="color: \
grey">(0aa2cdc33a88953fe8b94532cb45c43ad35e0da8)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(589fddb9ea2177102cabd3a193a9e6848ea9c12d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111510/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 