[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 110658: Playlist sort widget: reimplement Shuffle "sort" as an action.
From: "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date: 2013-05-27 16:09:43
Message-ID: 20130527160943.6656.27403 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110658/#review33229
-----------------------------------------------------------
src/playlist/PlaylistBreadcrumbItemSortButton.cpp
<http://git.reviewboard.kde.org/r/110658/#comment24580>
While you touch this anyway: This can be done more concisely with qMax(). Then \
you can maybe even make the variable const.
src/playlist/PlaylistBreadcrumbItemSortButton.cpp
<http://git.reviewboard.kde.org/r/110658/#comment24581>
Same as above, but qMin().
- Andreas Hartmetz
On May 27, 2013, 12:26 a.m., Konrad Zemek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110658/
> -----------------------------------------------------------
>
> (Updated May 27, 2013, 12:26 a.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Playlist sort widget: reimplement Shuffle "sort" as an action.
>
> Remove now-unnecessary Shuffle handlers in sort-related functions. Additionally, \
> PlaylistController::MoveRows has been modified to help with big move actions \
> (validation complexity reduced).
> GUI: In the playlist sort widget, the Shuffle menu entry is now separated from \
> other entries. Activating the entry no longer results in a "Shuffle" sort level \
> being added.
> BUG: 320129
> FIXED-IN: 2.8
>
>
> Diffs
> -----
>
> src/playlist/PlaylistActions.h dee8793e5386d3a44c98698631f6e8dd13a7d62f
> src/playlist/PlaylistActions.cpp 1decce7c3d7bef36f314b8abcc337064438a92e0
> src/playlist/PlaylistBreadcrumbItem.h d6ff243d7b78358f3a943de9a345d694c613aec9
> src/playlist/PlaylistBreadcrumbItem.cpp 59fc6d2a68d86e4d0cd4c1def343ac6973bc5965
> src/playlist/PlaylistBreadcrumbItemSortButton.h \
> c141597614ac40c3c4adaf212f3d46b9ff360293 \
> src/playlist/PlaylistBreadcrumbItemSortButton.cpp \
> 8bf861cfcd4234a0d34c3542b9fa806ce66454de src/playlist/PlaylistBreadcrumbLevel.cpp \
> 185ebfbafcbc3ef8ca80d9fd9ae42b0663a59eca src/playlist/PlaylistController.cpp \
> 95d2b828be0a6fa3c73998fe6681e57743788f1d src/playlist/PlaylistSortWidget.cpp \
> 62f760cc6a201a67be65c80bf03ae696bd44444c src/playlist/proxymodels/SortAlgorithms.h \
> 2eba6a7dd4c227f55d519083f9af9cf7b08f043d \
> src/playlist/proxymodels/SortAlgorithms.cpp \
> 47b468c99e37d3ff8b148704791c5058726ac812 src/playlist/proxymodels/SortScheme.cpp \
> d29f9dec6b1c2ae555146853782819328ae192f0 tests/playlist/TestPlaylistModels.h \
> 3751e6a2c3d56be1a6abcea742eec088e2a1123b tests/playlist/TestPlaylistModels.cpp \
> ec8adb8f2c5bbb141f291989499e361d5a73381d
> Diff: http://git.reviewboard.kde.org/r/110658/diff/
>
>
> Testing
> -------
>
> Test added for the shuffle action. GUI tested manually.
>
>
> Thanks,
>
> Konrad Zemek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110658/">http://git.reviewboard.kde.org/r/110658/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110658/diff/2/?file=146495#file146495line89" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/playlist/PlaylistBreadcrumbItemSortButton.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">BreadcrumbItemSortButton::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">69</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">preferredWidth</span> \
<span class="o"><</span> <span class="n">minimumWidth</span><span \
class="p">())</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While you \
touch this anyway: This can be done more concisely with qMax(). Then you can maybe \
even make the variable const.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110658/diff/2/?file=146495#file146495line91" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/playlist/PlaylistBreadcrumbItemSortButton.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">BreadcrumbItemSortButton::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">71</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">buttonWidth</span> <span \
class="o">></span> <span class="n">preferredWidth</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same as \
above, but qMin().</pre> </div>
<br />
<p>- Andreas</p>
<br />
<p>On May 27th, 2013, 12:26 a.m. UTC, Konrad Zemek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Konrad Zemek.</div>
<p style="color: grey;"><i>Updated May 27, 2013, 12:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Playlist sort widget: reimplement Shuffle "sort" as an action.
Remove now-unnecessary Shuffle handlers in sort-related functions. Additionally, \
PlaylistController::MoveRows has been modified to help with big move actions \
(validation complexity reduced).
GUI: In the playlist sort widget, the Shuffle menu entry is now separated from other \
entries. Activating the entry no longer results in a "Shuffle" sort level \
being added.
BUG: 320129
FIXED-IN: 2.8</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test added for the shuffle action. GUI tested manually.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlist/PlaylistActions.h <span style="color: \
grey">(dee8793e5386d3a44c98698631f6e8dd13a7d62f)</span></li>
<li>src/playlist/PlaylistActions.cpp <span style="color: \
grey">(1decce7c3d7bef36f314b8abcc337064438a92e0)</span></li>
<li>src/playlist/PlaylistBreadcrumbItem.h <span style="color: \
grey">(d6ff243d7b78358f3a943de9a345d694c613aec9)</span></li>
<li>src/playlist/PlaylistBreadcrumbItem.cpp <span style="color: \
grey">(59fc6d2a68d86e4d0cd4c1def343ac6973bc5965)</span></li>
<li>src/playlist/PlaylistBreadcrumbItemSortButton.h <span style="color: \
grey">(c141597614ac40c3c4adaf212f3d46b9ff360293)</span></li>
<li>src/playlist/PlaylistBreadcrumbItemSortButton.cpp <span style="color: \
grey">(8bf861cfcd4234a0d34c3542b9fa806ce66454de)</span></li>
<li>src/playlist/PlaylistBreadcrumbLevel.cpp <span style="color: \
grey">(185ebfbafcbc3ef8ca80d9fd9ae42b0663a59eca)</span></li>
<li>src/playlist/PlaylistController.cpp <span style="color: \
grey">(95d2b828be0a6fa3c73998fe6681e57743788f1d)</span></li>
<li>src/playlist/PlaylistSortWidget.cpp <span style="color: \
grey">(62f760cc6a201a67be65c80bf03ae696bd44444c)</span></li>
<li>src/playlist/proxymodels/SortAlgorithms.h <span style="color: \
grey">(2eba6a7dd4c227f55d519083f9af9cf7b08f043d)</span></li>
<li>src/playlist/proxymodels/SortAlgorithms.cpp <span style="color: \
grey">(47b468c99e37d3ff8b148704791c5058726ac812)</span></li>
<li>src/playlist/proxymodels/SortScheme.cpp <span style="color: \
grey">(d29f9dec6b1c2ae555146853782819328ae192f0)</span></li>
<li>tests/playlist/TestPlaylistModels.h <span style="color: \
grey">(3751e6a2c3d56be1a6abcea742eec088e2a1123b)</span></li>
<li>tests/playlist/TestPlaylistModels.cpp <span style="color: \
grey">(ec8adb8f2c5bbb141f291989499e361d5a73381d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110658/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic