'Re: Review Request 110426: KWalletHelper class for services using the KWallet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 110426: KWalletHelper class for services using the KWallet
From:       "Vedant Agarwala" <vedant.kota () gmail ! com>
Date:       2013-05-20 13:16:46
Message-ID: 20130520131646.17987.64015 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110426/
-----------------------------------------------------------

(Updated May 20, 2013, 1:16 p.m.)

Review request for Amarok.

Description
-------

I have created a KWalletHelper class so that services like Maganatune, Last.fm and \
GPodder can use this rather than duplicating code. Currently the patch applies only \
to Magnatune. The KWalletHelper class complies but it doesn't link properly to the \
MagnatuneConfig class.

Diffs
-----

  src/CMakeLists.txt 4dcb316 
  src/services/KWalletHelper.h e69de29 
  src/services/KWalletHelper.cpp e69de29 
  src/services/magnatune/CMakeLists.txt 91f24c0 
  src/services/magnatune/MagnatuneConfig.h 552bcf8 
  src/services/magnatune/MagnatuneConfig.cpp 5842c63 

Diff: http://git.reviewboard.kde.org/r/110426/diff/

Testing
-------

The KWalletHelper.cpp complies but fails to link to ManatuneConfig.cpp. Output of \
"make" command: http://paste.kde.org/743792/

Thanks,

Vedant Agarwala

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110426/">http://git.reviewboard.kde.org/r/110426/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Vedant Agarwala.</div>

<p style="color: grey;"><i>Updated May 20, 2013, 1:16 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have created a KWalletHelper class so that services like Maganatune, \
Last.fm and GPodder can use this rather than duplicating code. Currently the patch \
applies only to Magnatune. The KWalletHelper class complies but it doesn&#39;t link \
properly to the MagnatuneConfig class.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The KWalletHelper.cpp complies but fails to link to ManatuneConfig.cpp. \
Output of &quot;make&quot; command: http://paste.kde.org/743792/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(4dcb316)</span></li>

 <li>src/services/KWalletHelper.h <span style="color: grey">(e69de29)</span></li>

 <li>src/services/KWalletHelper.cpp <span style="color: grey">(e69de29)</span></li>

 <li>src/services/magnatune/CMakeLists.txt <span style="color: \
grey">(91f24c0)</span></li>

 <li>src/services/magnatune/MagnatuneConfig.h <span style="color: \
grey">(552bcf8)</span></li>

 <li>src/services/magnatune/MagnatuneConfig.cpp <span style="color: \
grey">(5842c63)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110426/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 