'Re: Review Request 110520: create new collections without restart'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 110520: create new collections without restart
From:       "Mark Kretschmann" <kretschmann () kde ! org>
Date:       2013-05-20 8:18:10
Message-ID: 20130520081810.9014.53984 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110520/#review32797
-----------------------------------------------------------

This works nicely. To make it complete, could we also remove collections immediately \
when the plugin is being disabled?

- Mark Kretschmann

On May 19, 2013, 8:43 a.m., Edward Hades Toroshchin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110520/
> -----------------------------------------------------------
> 
> (Updated May 19, 2013, 8:43 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> create new collections without restart
> 
> 
> Diffs
> -----
> 
> src/PluginManager.cpp fc825cece9d06a92a9a84a1dcfa949bfc6c14ed8 
> src/core-impl/collections/support/CollectionManager.h \
> a3cb6cefc958fb2875c7bef075f4a5319fc8b958  \
> src/core-impl/collections/support/CollectionManager.cpp \
> 0775206655b47d660c92bf6ebf23623de356bb69  
> Diff: http://git.reviewboard.kde.org/r/110520/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Edward Hades Toroshchin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110520/">http://git.reviewboard.kde.org/r/110520/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This works nicely. To \
make it complete, could we also remove collections immediately when the plugin is \
being disabled?</pre>  <br />

<p>- Mark</p>

<br />
<p>On May 19th, 2013, 8:43 a.m. UTC, Edward Hades Toroshchin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Edward Hades Toroshchin.</div>

<p style="color: grey;"><i>Updated May 19, 2013, 8:43 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">create new collections without restart</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/PluginManager.cpp <span style="color: \
grey">(fc825cece9d06a92a9a84a1dcfa949bfc6c14ed8)</span></li>

 <li>src/core-impl/collections/support/CollectionManager.h <span style="color: \
grey">(a3cb6cefc958fb2875c7bef075f4a5319fc8b958)</span></li>

 <li>src/core-impl/collections/support/CollectionManager.cpp <span style="color: \
grey">(0775206655b47d660c92bf6ebf23623de356bb69)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110520/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 