[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files
From: "Edward Hades Toroshchin" <edward.hades () gmail ! com>
Date: 2013-04-25 15:42:56
Message-ID: 20130425154256.14345.59168 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110187/#review31576
-----------------------------------------------------------
Thanks for the fix. However, this is the approach, we've used originally, and it \
didn't prove very reliable. I think we even went back and forth more than once.
So you should really have a look in the history of the mysql collection, to see if \
and how this is different from the way it's been done before (and why it isn't done \
that way anymore).
> This fixes an issue where amarok is writing the database to "C:\Program Files \
> (x86)\Amarok\data\amarok". This issue prevents Amarok from running correctly, \
> because regarding to the rights of the useraccount the directory can be not \
> writeable.
It's not only that, it could also lead to problems if several users tried to use \
Amarok simultaneously.
I suggest you check, where does this path come from. Why is storageLocation empty?
- Edward Hades Toroshchin
On April 25, 2013, 2:36 p.m., Patrick von Reth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110187/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 2:36 p.m.)
>
>
> Review request for Amarok.
>
>
> Description
> -------
>
> Don't communicate with mysql by env vars and autogenerated files
>
> Instead of generating the my.cnf every time amarok starts and to pass
> the location of this file by setting an environment variable directly
> pass the settings as arguments to mysql. As this is probably a better
> approach and the only one working on windows.
>
> This fixes an issue where amarok is writing the database to "C:\Program Files \
> (x86)\Amarok\data\amarok". This issue prevents Amarok from running correctly, \
> because regarding to the rights of the useraccount the directory can be not \
> writeable.
> The commands used are taken from the output of "mysqld --verbose --help".
>
>
> Diffs
> -----
>
> src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp \
> 0233498fdeb18ab51e709e9a78384fc37c47cb2a
> Diff: http://git.reviewboard.kde.org/r/110187/diff/
>
>
> Testing
> -------
>
> Only on windows
>
>
> Thanks,
>
> Patrick von Reth
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110187/">http://git.reviewboard.kde.org/r/110187/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the fix. \
However, this is the approach, we've used originally, and it didn't prove \
very reliable. I think we even went back and forth more than once.
So you should really have a look in the history of the mysql collection, to see if \
and how this is different from the way it's been done before (and why it \
isn't done that way anymore).
> This fixes an issue where amarok is writing the database to "C:\Program \
Files (x86)\Amarok\data\amarok". > This issue prevents Amarok from running \
correctly, because regarding to the rights of the useraccount the directory can be \
not writeable.
It's not only that, it could also lead to problems if several users tried to use \
Amarok simultaneously.
I suggest you check, where does this path come from. Why is storageLocation \
empty?</pre> <br />
<p>- Edward Hades</p>
<br />
<p>On April 25th, 2013, 2:36 p.m. UTC, Patrick von Reth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Patrick von Reth.</div>
<p style="color: grey;"><i>Updated April 25, 2013, 2:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Don't communicate with mysql by env vars and autogenerated files
Instead of generating the my.cnf every time amarok starts and to pass
the location of this file by setting an environment variable directly
pass the settings as arguments to mysql. As this is probably a better
approach and the only one working on windows.
This fixes an issue where amarok is writing the database to "C:\Program Files \
(x86)\Amarok\data\amarok". This issue prevents Amarok from running correctly, \
because regarding to the rights of the useraccount the directory can be not \
writeable.
The commands used are taken from the output of "mysqld --verbose --help". \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Only on windows</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp <span \
style="color: grey">(0233498fdeb18ab51e709e9a78384fc37c47cb2a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110187/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic