'Re: Review Request 110036: WIP - Simple equalizer scripting'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request 110036: WIP - Simple equalizer scripting
From:       "Ryan McCoskrie" <ryan.mccoskrie () gmail ! com>
Date:       2013-04-18 7:50:13
Message-ID: 20130418075013.6116.7606 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110036/
-----------------------------------------------------------

(Updated April 18, 2013, 7:50 a.m.)

Review request for Amarok.

Description
-------

A new, unambitious attempt at adding equalizer functions to the scripting interface.

Adds to EngineController the functions:
* QString eqPreset()
* void eqApplyPreset(QString name)
And the signal:
eqPresetApplied(QString name)

Adds to AmarokEngineScript the same functions
set up as a property.

Diffs (updated)
-----

  src/scriptengine/AmarokEngineScript.cpp 4d52bbe 
  src/scriptengine/AmarokEngineScript.h f1cdb8c 
  src/EngineController.cpp 28fb256 
  src/EngineController.h 5de4beb 

Diff: http://git.reviewboard.kde.org/r/110036/diff/

Testing
-------

Quick check using the script console that presets can be changed.
The preset does get applied but it won't show in the EqualizerDialog.
Possible other bugs.

Thanks,

Ryan McCoskrie

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110036/">http://git.reviewboard.kde.org/r/110036/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok.</div>
<div>By Ryan McCoskrie.</div>

<p style="color: grey;"><i>Updated April 18, 2013, 7:50 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A new, unambitious attempt at adding equalizer functions to the \
scripting interface.

Adds to EngineController the functions:
* QString eqPreset()
* void eqApplyPreset(QString name)
And the signal:
eqPresetApplied(QString name)

Adds to AmarokEngineScript the same functions
set up as a property.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Quick check using the script console that presets can be changed. The \
preset does get applied but it won&#39;t show in the EqualizerDialog. Possible other \
bugs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/scriptengine/AmarokEngineScript.cpp <span style="color: \
grey">(4d52bbe)</span></li>

 <li>src/scriptengine/AmarokEngineScript.h <span style="color: \
grey">(f1cdb8c)</span></li>

 <li>src/EngineController.cpp <span style="color: grey">(28fb256)</span></li>

 <li>src/EngineController.h <span style="color: grey">(5de4beb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110036/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 