[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection
From: "Phalgun Guduthur" <phalgun.guduthur () gmail ! com>
Date: 2012-10-31 19:35:58
Message-ID: 20121031193558.29081.57574 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107161/
-----------------------------------------------------------
Review request for Amarok, Edward Hades Toroshchin and Vishesh Handa.
Description
-------
First footstep in completing the Nepomuk Collection. =
The non virtual methods belonging to TrackProvider implemented.
Repeated documentation to help vHanda understand the purpose of those funct=
ions. =
Diffs
-----
src/core-impl/collections/nepomukcollection/NepomukCollection.h d920ff6 =
src/core-impl/collections/nepomukcollection/NepomukCollection.cpp 0593697 =
Diff: http://git.reviewboard.kde.org/r/107161/diff/
Testing
-------
Minimal.
Thanks,
Phalgun Guduthur
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107161/">http://git.reviewboard.kde.org/r/107161/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok, Edward Hades Toroshchin and Vishesh Handa.</div>
<div>By Phalgun Guduthur.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First footstep in completing the Nepomuk Collection.
The non virtual methods belonging to TrackProvider implemented.
Repeated documentation to help vHanda understand the purpose of those functions.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Minimal.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/nepomukcollection/NepomukCollection.h <span \
style="color: grey">(d920ff6)</span></li>
<li>src/core-impl/collections/nepomukcollection/NepomukCollection.cpp <span \
style="color: grey">(0593697)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107161/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic