This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106566/

core/Player.h (Diff revision 1) 

   
public:


  

 




 
 



 

  

    
    

    24
    
    void play();

  


  

    
    

    25
    
    void pause();

  


  

    
    

    26
    
    void stop();

  


 





Missing documentation, e.g. if calling pause() on a Stopped Player has any effect etc.














 
  

   
    core/Player.h
    

     (Diff revision 1)

    
   
  

 

 
  


   

   
public:


  

 




 
 



 

  

    
    

    42
    
signals:

  


  

    
    

    43
    
    void stateChanged(State newState, State oldState);

  


  

    
    

    44
    
    void finished();

  


 





aboutToFinish() gone?

I wanted to comment on aboutToFinish() - it is currently very tricky to use that because currently it is sometimes emitted twice or not at all per one media source. I'd like if the docs would somehow limit this behaviour.














 
  

   
    core/Queue.h
    

     (Diff revision 1)

    
   
  

 

 
  


   

   
class Queue {


  

 




 
 



 

  

    
    

    44
    
        void handleAboutToFinish() {

  


  

    
    

    45
    
            m_player->setSource(m_items.takeFirst());

  


  

    
    

    46
    
        }

  


 





Eya, is this a symbolic code? Otherwise this looks like it would cut the track if aboutToFinish is emitted prematurely etc.














 
  

   
    core/Source.h
    

     (Diff revision 1)

    
   
  

 

 
  


   

   
public:


  

 




 
 



 

  

    
    

    19
    
        Stream,

  


 





Bart, these are not class names..









- Matěj






On September 25th, 2012, 11:06 a.m., Harald Sitter wrote:









 

  


Review request for Amarok and Phonon.


By Harald Sitter.




Updated Sept. 25, 2012, 11:06 a.m.








Description 

 

 

  
   
phonon phive core frontend api

  		
 









Diffs 


    

 
  • core/AudioDataOutput.h (PRE-CREATION)
    • 

 
  • core/AudioDataOutput.cpp (PRE-CREATION)
    • 

 
  • core/AudioOutput.h (PRE-CREATION)
    • 

 
  • core/AudioOutput.cpp (PRE-CREATION)
    • 

 
  • core/BackendCapabilities.h (PRE-CREATION)
    • 

 
  • core/BackendCapabilities.cpp (PRE-CREATION)
    • 

 
  • core/OutputEffect.h (PRE-CREATION)
    • 

 
  • core/OutputEffect.cpp (PRE-CREATION)
    • 

 
  • core/Player.h (PRE-CREATION)
    • 

 
  • core/Player.cpp (PRE-CREATION)
    • 

 
  • core/Queue.h (PRE-CREATION)
    • 

 
  • core/Queue.cpp (PRE-CREATION)
    • 

 
  • core/Source.h (PRE-CREATION)
    • 

 
  • core/Source.cpp (PRE-CREATION)
    • 

 
  • core/VideoDataOutput.h (PRE-CREATION)
    • 

 
  • core/VideoDataOutput.cpp (PRE-CREATION)
    • 

 
  • core/abstract/AbstractAudioOutput.h (PRE-CREATION)
    • 

 
  • core/abstract/AbstractAudioOutput.cpp (PRE-CREATION)
    • 

 
  • core/abstract/AbstractMediaStream.h (PRE-CREATION)
    • 

 
  • core/abstract/AbstractMediaStream.cpp (PRE-CREATION)
    • 

 
  • core/abstract/AbstractVideoOutput.h (PRE-CREATION)
    • 

 
  • core/abstract/AbstractVideoOutput.cpp (PRE-CREATION)
    • 

 
  • core/core.pro (PRE-CREATION)
    • 

 
  • core/effects/SubtitleEffect.h (PRE-CREATION)
    • 

 
  • core/effects/SubtitleEffect.cpp (PRE-CREATION)
    • 

 
  • core/five_global.h (PRE-CREATION)
    • 





View Diff