From amarok-devel Sat Sep 29 12:26:18 2012 From: =?utf-8?q?Mat=C4=9Bj_Laitl?= Date: Sat, 29 Sep 2012 12:26:18 +0000 To: amarok-devel Subject: Re: Review Request: phonon phive core frontend api Message-Id: <20120929122618.20979.53077 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=amarok-devel&m=134892160219899 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7271697815199997106==" --===============7271697815199997106== Content-Type: multipart/alternative; boundary="===============0369396044757139575==" --===============0369396044757139575== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106566/#review19569 ----------------------------------------------------------- core/Player.h Missing documentation, e.g. if calling pause() on a Stopped Player has = any effect etc. core/Player.h aboutToFinish() gone? = I wanted to comment on aboutToFinish() - it is currently very tricky to= use that because currently it is sometimes emitted twice or not at all per= one media source. I'd like if the docs would somehow limit this behaviour. core/Queue.h Eya, is this a symbolic code? Otherwise this looks like it would cut th= e track if aboutToFinish is emitted prematurely etc. core/Source.h Bart, these are not class names.. - Mat=C4=9Bj Laitl On Sept. 25, 2012, 11:06 a.m., Harald Sitter wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106566/ > ----------------------------------------------------------- > = > (Updated Sept. 25, 2012, 11:06 a.m.) > = > = > Review request for Amarok and Phonon. > = > = > Description > ------- > = > phonon phive core frontend api > = > = > Diffs > ----- > = > core/AudioDataOutput.h PRE-CREATION = > core/AudioDataOutput.cpp PRE-CREATION = > core/AudioOutput.h PRE-CREATION = > core/AudioOutput.cpp PRE-CREATION = > core/BackendCapabilities.h PRE-CREATION = > core/BackendCapabilities.cpp PRE-CREATION = > core/OutputEffect.h PRE-CREATION = > core/OutputEffect.cpp PRE-CREATION = > core/Player.h PRE-CREATION = > core/Player.cpp PRE-CREATION = > core/Queue.h PRE-CREATION = > core/Queue.cpp PRE-CREATION = > core/Source.h PRE-CREATION = > core/Source.cpp PRE-CREATION = > core/VideoDataOutput.h PRE-CREATION = > core/VideoDataOutput.cpp PRE-CREATION = > core/abstract/AbstractAudioOutput.h PRE-CREATION = > core/abstract/AbstractAudioOutput.cpp PRE-CREATION = > core/abstract/AbstractMediaStream.h PRE-CREATION = > core/abstract/AbstractMediaStream.cpp PRE-CREATION = > core/abstract/AbstractVideoOutput.h PRE-CREATION = > core/abstract/AbstractVideoOutput.cpp PRE-CREATION = > core/core.pro PRE-CREATION = > core/effects/SubtitleEffect.h PRE-CREATION = > core/effects/SubtitleEffect.cpp PRE-CREATION = > core/five_global.h PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/106566/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Harald Sitter > = > --===============0369396044757139575== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106566/

= =

core/Player.h (Diff revision 1)
	public:
		24	void play();
		25	void pause();
		26	void stop();

Missing documentation, e.g. if calling pause() on a Stopped Player h=
as any effect etc.

= =

core/Player.h (Diff revision 1)
	public:
		42	signals:
		43	void stateChanged(State= newState, State oldState= );
		44	void finished();

aboutToFinish() gone?

I wanted to comment on aboutToFinish() - it is currently very tricky to use=
 that because currently it is sometimes emitted twice or not at all per one=
 media source. I'd like if the docs would somehow limit this behaviour.=

= =

core/Queue.h (Diff revision 1)
	class Queue {
		44	void handleAboutToFinish() {
		45	m_player<= span class=3D"o">->setSource(m_items.takeFirst());
		46	}

Eya, is this a symbolic code? Otherwise this looks like it would cut=
 the track if aboutToFinish is emitted prematurely etc.

= =

core/Source.h (Diff revision 1)
	public:
		19	Stream,

Bart, these are not class names..

- Mat=C4=9Bj

On September 25th, 2012, 11:06 a.m., Harald Sitter wrote:

Review request for Amarok and Phonon.

By Harald Sitter.

Updated Sept. 25, 2012, 11:06 a.m.

Descripti= on

phonon phive core frontend api

Diffs=

core/AudioDataOutput.h (PRE-CREATION)
core/AudioDataOutput.cpp (PRE-CREATION)
core/AudioOutput.h (PRE-CREATION)
core/AudioOutput.cpp (PRE-CREATION)=
core/BackendCapabilities.h (PRE-CREATION)<= /span>
core/BackendCapabilities.cpp (PRE-CREATION= )
core/OutputEffect.h (PRE-CREATION)<= /li>
core/OutputEffect.cpp (PRE-CREATION)
core/Player.h (PRE-CREATION)
core/Player.cpp (PRE-CREATION)
core/Queue.h (PRE-CREATION)
core/Queue.cpp (PRE-CREATION)
core/Source.h (PRE-CREATION)
core/Source.cpp (PRE-CREATION)
core/VideoDataOutput.h (PRE-CREATION)
core/VideoDataOutput.cpp (PRE-CREATION)
core/abstract/AbstractAudioOutput.h (PRE-C= REATION)
core/abstract/AbstractAudioOutput.cpp (PRE= -CREATION)
core/abstract/AbstractMediaStream.h (PRE-C= REATION)
core/abstract/AbstractMediaStream.cpp (PRE= -CREATION)
core/abstract/AbstractVideoOutput.h (PRE-C= REATION)
core/abstract/AbstractVideoOutput.cpp (PRE= -CREATION)
core/core.pro (PRE-CREATION)
core/effects/SubtitleEffect.h (PRE-CREATIO= N)
core/effects/SubtitleEffect.cpp (PRE-CREAT= ION)
core/five_global.h (PRE-CREATION)

--===============0369396044757139575==-- --===============7271697815199997106== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel --===============7271697815199997106==--