[prev in list] [next in list] [prev in thread] [next in thread]
List: amarok-devel
Subject: Re: Review Request: liblastfm1 port
From: Matěj_Laitl <matej () laitl ! cz>
Date: 2012-06-16 22:56:50
Message-ID: 20120616225650.31709.76435 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105276/#review14802
-----------------------------------------------------------
Thanks for it, I'll try to review it soon. From quick look I miss changed R=
EADME and a ChangeLog entry. (but you may want to wait with the ChangeLog a=
fter 2.6 is released) I agree with raising the liblastfm dependency to 1.0,=
Amarok 2.7 won't be released sooner than autumn and that's enough time for=
distros for this optional feature.
- Mat=C4=9Bj Laitl
On June 16, 2012, 10:50 p.m., Harald Sitter wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105276/
> -----------------------------------------------------------
> =
> (Updated June 16, 2012, 10:50 p.m.)
> =
> =
> Review request for Amarok.
> =
> =
> Description
> -------
> =
> port to liblastfm1, mind that this is slightly api incompatible with libl=
astfm0, and retaining ifdef compat does not seem worthwhile given the fact =
that latter uses exceptions and former does not
> =
> =
> Diffs
> -----
> =
> src/services/ampache/LastfmInfoParser.cpp 50cb529516ce1358785fa04824cd3=
2642a526495 =
> src/services/lastfm/LastFmService.cpp a14d989b3fac81e545df095adee36580b=
052fea7 =
> src/services/lastfm/LastFmServiceCollection.cpp 22f49ec0fe8e9f917f8a26f=
9d546ad147ad04e5b =
> src/services/lastfm/LastFmServiceSettings.cpp 2eff71e51dc30605b4d395323=
a01e24b8fa25d1e =
> src/services/lastfm/LastFmTreeModel.h ac171a57a36ec6bb5443035b11bea77e4=
ae94720 =
> src/services/lastfm/LastFmTreeModel.cpp 2d94d67c5fe10bfc1abba3dd9848fd1=
177daa518 =
> src/services/lastfm/ScrobblerAdapter.h 67ed73b291cef61ee37b0ddae28ba1ea=
dfd6304d =
> src/services/lastfm/biases/LastFmBias.cpp b011b3299f98d851109d3d9ba52e6=
fd09855dcff =
> src/services/lastfm/biases/WeeklyTopBias.cpp df6dd6681f05d95a0e281d6e82=
224de2bbf001e6 =
> src/services/lastfm/meta/LastFmMeta.h f7b93c14c92c0bebf99d165656a0e34f8=
b991cc0 =
> src/services/lastfm/meta/LastFmMeta.cpp d8f52845cb801d8ae940bc1bca77c72=
81ef18379 =
> src/services/lastfm/meta/LastFmMeta_p.h c2d88ac79a4dd0fe59b9f889baf72c8=
79833f0d3 =
> src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h 1c464cc2635c7d=
614eab48ca5e4e156c67870f04 =
> src/context/engines/upcomingevents/UpcomingEventsEngine.cpp 4ae73d892ce=
f3d4a41662f7ed15849ae773c16e3 =
> src/core/support/Amarok.h c9852154dee74fb372bae435fdeefa92003d41b1 =
> CMakeLists.txt 0d146c58bd382b4d4f379ebedddf1630d73db369 =
> cmake/modules/FindLibLastFm.cmake 1d863b08489e27054a049e35d2d94667646db=
1f7 =
> src/LastfmReadLabelCapability.cpp 385e6b9c065009b330e116e3d748b82c24f14=
e8d =
> =
> Diff: http://git.reviewboard.kde.org/r/105276/diff/
> =
> =
> Testing
> -------
> =
> [~] login test in settings (for some reason the service does not pick up =
changes there until restart, which seems actually architectural as the KCM =
does not trigger reinitialization of the service)
> [+] streaming
> [+] love
> [+] ban
> [+] next
> [+] friends/neighbors
> [+] upcoming events plasmoid
> [+] related artists plasmoid
> =
> =
> Thanks,
> =
> Harald Sitter
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105276/">http://git.reviewboard.kde.org/r/105276/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for it, I'll \
try to review it soon. From quick look I miss changed README and a ChangeLog entry. \
(but you may want to wait with the ChangeLog after 2.6 is released) I agree with \
raising the liblastfm dependency to 1.0, Amarok 2.7 won't be released sooner than \
autumn and that's enough time for distros for this optional feature.</pre> <br \
/>
<p>- Matěj</p>
<br />
<p>On June 16th, 2012, 10:50 p.m., Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Amarok.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated June 16, 2012, 10:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">port to liblastfm1, mind that this is slightly api incompatible with \
liblastfm0, and retaining ifdef compat does not seem worthwhile given the fact that \
latter uses exceptions and former does not</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[~] login test in settings (for some reason the service does not pick up \
changes there until restart, which seems actually architectural as the KCM does not \
trigger reinitialization of the service) [+] streaming
[+] love
[+] ban
[+] next
[+] friends/neighbors
[+] upcoming events plasmoid
[+] related artists plasmoid
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/ampache/LastfmInfoParser.cpp <span style="color: \
grey">(50cb529516ce1358785fa04824cd32642a526495)</span></li>
<li>src/services/lastfm/LastFmService.cpp <span style="color: \
grey">(a14d989b3fac81e545df095adee36580b052fea7)</span></li>
<li>src/services/lastfm/LastFmServiceCollection.cpp <span style="color: \
grey">(22f49ec0fe8e9f917f8a26f9d546ad147ad04e5b)</span></li>
<li>src/services/lastfm/LastFmServiceSettings.cpp <span style="color: \
grey">(2eff71e51dc30605b4d395323a01e24b8fa25d1e)</span></li>
<li>src/services/lastfm/LastFmTreeModel.h <span style="color: \
grey">(ac171a57a36ec6bb5443035b11bea77e4ae94720)</span></li>
<li>src/services/lastfm/LastFmTreeModel.cpp <span style="color: \
grey">(2d94d67c5fe10bfc1abba3dd9848fd1177daa518)</span></li>
<li>src/services/lastfm/ScrobblerAdapter.h <span style="color: \
grey">(67ed73b291cef61ee37b0ddae28ba1eadfd6304d)</span></li>
<li>src/services/lastfm/biases/LastFmBias.cpp <span style="color: \
grey">(b011b3299f98d851109d3d9ba52e6fd09855dcff)</span></li>
<li>src/services/lastfm/biases/WeeklyTopBias.cpp <span style="color: \
grey">(df6dd6681f05d95a0e281d6e82224de2bbf001e6)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.h <span style="color: \
grey">(f7b93c14c92c0bebf99d165656a0e34f8b991cc0)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: \
grey">(d8f52845cb801d8ae940bc1bca77c7281ef18379)</span></li>
<li>src/services/lastfm/meta/LastFmMeta_p.h <span style="color: \
grey">(c2d88ac79a4dd0fe59b9f889baf72c879833f0d3)</span></li>
<li>src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h <span style="color: \
grey">(1c464cc2635c7d614eab48ca5e4e156c67870f04)</span></li>
<li>src/context/engines/upcomingevents/UpcomingEventsEngine.cpp <span style="color: \
grey">(4ae73d892cef3d4a41662f7ed15849ae773c16e3)</span></li>
<li>src/core/support/Amarok.h <span style="color: \
grey">(c9852154dee74fb372bae435fdeefa92003d41b1)</span></li>
<li>CMakeLists.txt <span style="color: \
grey">(0d146c58bd382b4d4f379ebedddf1630d73db369)</span></li>
<li>cmake/modules/FindLibLastFm.cmake <span style="color: \
grey">(1d863b08489e27054a049e35d2d94667646db1f7)</span></li>
<li>src/LastfmReadLabelCapability.cpp <span style="color: \
grey">(385e6b9c065009b330e116e3d748b82c24f14e8d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic