[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Amarok 2.5.0 has a bad memory leak
From:       Kevin Funk <krf () gmx ! de>
Date:       2012-05-25 18:20:22
Message-ID: 1601607.CQtIePlqlB () kerberos
[Download RAW message or body]

On Wednesday 23 May 2012, 15:16, Erik Hovland wrote:
> > Out of curiosity:
> > Why use a QShardPointer and not directly allocate the object on the stack?
> > Would do the same.
> 
> You're probably right. I was staring at the code too long to recognize such
> simplicity. Reworked patch attached.
> 
> E

Not a good fix either,

you assume that BreadcrumbItem doesn't store the pointer for bLevel. bLevel 
gets destroyed and the end of the block, though.

From a quick glance at the code I actually wonder why the BreadcrumbLevel 
class is even needed. It's only really used in the PlaylistBreadcrumbItem 
ctor, where just BreadcrumbLevel::name() is referenced.

So, imo, the best fix is to just pass a QString to BreadcrumbItem (here: 
internalColumnName) and drop the BreadcrumbLevel class.

Greets

-- 
Kevin Funk
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
[prev in list] [next in list] [prev in thread] [next in thread]