'Re: Review Request: GPodder Improvements Patch Rev1'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       amarok-devel
Subject:    Re: Review Request: GPodder Improvements Patch Rev1
From:       "Lucas Gomes" <x8lucas8x () gmail ! com>
Date:       2012-03-19 19:40:54
Message-ID: 20120319194054.11893.50743 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/
-----------------------------------------------------------

(Updated March 19, 2012, 7:40 p.m.)

Review request for Amarok, Stefan Derkits and Bart Cerneels.

Summary (updated)
-----------------

GPodder Improvements Patch Rev1

Description (updated)
-------

GPodder Service improvements Rev1

Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.

GPodder Service improvements

Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.

Diffs (updated)
-----

  ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 =

  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 0a450ae2420de11=
ab221cf2dec9fc942a7118dd1 =

  src/browsers/playlistbrowser/PodcastModel.h e88f4a1dea0b41ce6cc21cdbe3809=
b99c200b5b8 =

  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6eb970eed241f172cc713=
96cca8bcaf04b =

  src/core-impl/podcasts/sql/SqlPodcastProvider.h c3d5e56e79c86e2be8c39f47d=
f928bfeb291a920 =

  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f652989167952b0c8=
cf16e742de2fb94e1 =

  src/services/gpodder/GpodderPodcastRequestHandler.h 8c12e5f5a5a63b91670fd=
8081018b7a017a00bbe =

  src/services/gpodder/GpodderPodcastRequestHandler.cpp 66e8ea8a3aeec054c82=
a180f84d199aba5547f5a =

  src/services/gpodder/GpodderProvider.h 4c724cd763b94515e9e90620ad9a4a3fb8=
f92e2c =

  src/services/gpodder/GpodderProvider.cpp 6e3255e5f465287a9fad3454cca5a1d2=
ce47fc6a =

  src/services/gpodder/GpodderService.cpp b518de33e01d20c7293c50e9edbb2dff7=
8419e53 =

  src/services/gpodder/GpodderServiceConfig.h 111455aeeb2a579caf1dd938249b8=
d832a775a89 =

  src/services/gpodder/GpodderServiceConfig.cpp 750272e4f2c6c7ad411e9d12c62=
2e97789a29bcd =

  src/services/gpodder/GpodderServiceSettings.h 81bc218428d2b8bc78235852548=
a337579b35b24 =

  src/services/gpodder/GpodderServiceSettings.cpp 8bb8b806927d1dbac47f2a068=
87c2e2a6dd3d504 =

  src/services/gpodder/GpodderSortFilterProxyModel.h 638fe992cba553cc317feb=
df049b6b0f301018b5 =

  src/services/gpodder/GpodderSortFilterProxyModel.cpp ed1e8301f6f415e86e53=
67b7827817fff45feb98 =

Diff: http://git.reviewboard.kde.org/r/104335/diff/

Testing
-------

This patch should build. Everything is working as expected and there aren't=
 any known issues.

Thanks,

Lucas Gomes

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104335/">http://git.reviewboard.kde.org/r/104335/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>

<p style="color: grey;"><i>Updated March 19, 2012, 7:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">GPodder Improvements Patch Rev1</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">GPodder Service improvements Rev1

Put messages to show that gpodder service failed to get data from
gpodder.net. Done some cleanup and added some comments.

GPodder Service improvements

Full status synchronisation implemented. Cleanup and some refactoring.
GPodder Provider saves podcast subscriptions changes if the user closes
amarok before a expected synchronisation to end, so as to synchronize them
in the next start. Forcing GPodderService to verify if the username and
password is not empty before creating a mygpo::ApiRequest. Solved some
problems related to the KWallet use in GPodderService.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch should build. Everything is working as expected and there \
aren&#39;t any known issues.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>ChangeLog <span style="color: \
grey">(0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4)</span></li>

 <li>src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp <span style="color: \
grey">(0a450ae2420de11ab221cf2dec9fc942a7118dd1)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.h <span style="color: \
grey">(e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8)</span></li>

 <li>src/browsers/playlistbrowser/PodcastModel.cpp <span style="color: \
grey">(18334f6eb970eed241f172cc71396cca8bcaf04b)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastProvider.h <span style="color: \
grey">(c3d5e56e79c86e2be8c39f47df928bfeb291a920)</span></li>

 <li>src/core-impl/podcasts/sql/SqlPodcastProvider.cpp <span style="color: \
grey">(183005f652989167952b0c8cf16e742de2fb94e1)</span></li>

 <li>src/services/gpodder/GpodderPodcastRequestHandler.h <span style="color: \
grey">(8c12e5f5a5a63b91670fd8081018b7a017a00bbe)</span></li>

 <li>src/services/gpodder/GpodderPodcastRequestHandler.cpp <span style="color: \
grey">(66e8ea8a3aeec054c82a180f84d199aba5547f5a)</span></li>

 <li>src/services/gpodder/GpodderProvider.h <span style="color: \
grey">(4c724cd763b94515e9e90620ad9a4a3fb8f92e2c)</span></li>

 <li>src/services/gpodder/GpodderProvider.cpp <span style="color: \
grey">(6e3255e5f465287a9fad3454cca5a1d2ce47fc6a)</span></li>

 <li>src/services/gpodder/GpodderService.cpp <span style="color: \
grey">(b518de33e01d20c7293c50e9edbb2dff78419e53)</span></li>

 <li>src/services/gpodder/GpodderServiceConfig.h <span style="color: \
grey">(111455aeeb2a579caf1dd938249b8d832a775a89)</span></li>

 <li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: \
grey">(750272e4f2c6c7ad411e9d12c622e97789a29bcd)</span></li>

 <li>src/services/gpodder/GpodderServiceSettings.h <span style="color: \
grey">(81bc218428d2b8bc78235852548a337579b35b24)</span></li>

 <li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: \
grey">(8bb8b806927d1dbac47f2a06887c2e2a6dd3d504)</span></li>

 <li>src/services/gpodder/GpodderSortFilterProxyModel.h <span style="color: \
grey">(638fe992cba553cc317febdf049b6b0f301018b5)</span></li>

 <li>src/services/gpodder/GpodderSortFilterProxyModel.cpp <span style="color: \
grey">(ed1e8301f6f415e86e5367b7827817fff45feb98)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104335/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

[prev in list] [next in list] [prev in thread] [next in thread] 